Go: Avoid using getTarget() as it may not exist #13785

owen-mc · 2023-07-20T16:05:46Z

Try to also deal with the case that we are calling a function through a variable that it has been assigned to.

smowton · 2023-07-27T12:41:55Z

Worth noting that this changes behaviour somewhat: now if the receiver is of non-interface type but the callee is promoted from an embedded interface, we'll call this a non-interface call and propagate the receiver into it. Contrast the old test which I think looked at getACalleeSource instead of getTarget, and would have maintained the same behaviour regarding that scenario.

Avoid using getTarget() as it may not exist

e109280

Try to also deal with the case that we are calling a function through a variable that it has been assigned to.

owen-mc changed the title ~~Avoid using getTarget() as it may not exist~~ Go: Avoid using getTarget() as it may not exist Jul 20, 2023

github-actions bot added the Go label Jul 20, 2023

Go: Avoid using getTarget() as it may not exist #13785

Go: Avoid using getTarget() as it may not exist #13785

owen-mc commented Jul 20, 2023

smowton commented Jul 27, 2023

Go: Avoid using getTarget() as it may not exist #13785

Are you sure you want to change the base?

Go: Avoid using getTarget() as it may not exist #13785

Conversation

owen-mc commented Jul 20, 2023

smowton commented Jul 27, 2023