Skip to content

java convenction changes#4259

Merged
siriak merged 9 commits into
TheAlgorithms:masterfrom
RANJEETJ06:master-3
Jul 27, 2023
Merged

java convenction changes#4259
siriak merged 9 commits into
TheAlgorithms:masterfrom
RANJEETJ06:master-3

Conversation

@RANJEETJ06
Copy link
Copy Markdown
Contributor

@RANJEETJ06 RANJEETJ06 commented Jul 25, 2023 •
edited
Loading

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

@RANJEETJ06 RANJEETJ06 changed the title Master 3 java convenction changes Jul 25, 2023
siriak
siriak reviewed Jul 26, 2023
View reviewed changes
Comment thread src/main/java/com/thealgorithms/datastructures/trees/GenericTree.java Outdated
RANJEETJ06 and others added 2 commits July 26, 2023 19:35
@RANJEETJ06 @siriak
Update src/main/java/com/thealgorithms/datastructures/trees/GenericTr…
39b32a2 
…ee.java


Yes that would be better

Co-authored-by: Andrii Siriak <siryaka@gmail.com>
@RANJEETJ06
Merge branch 'master' into master-3
1aee4d6
@RANJEETJ06 RANJEETJ06 closed this Jul 26, 2023
@RANJEETJ06 RANJEETJ06 reopened this Jul 26, 2023
siriak
siriak previously approved these changes Jul 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak
Copy link
Copy Markdown
Member

siriak commented Jul 26, 2023

The build is failing because you forgot to update usage of parameters in the function

@RANJEETJ06 RANJEETJ06 closed this Jul 26, 2023
@RANJEETJ06 RANJEETJ06 reopened this Jul 26, 2023
@RANJEETJ06
Copy link
Copy Markdown
Contributor Author

RANJEETJ06 commented Jul 26, 2023

how to fix it i don't know

siriak
siriak approved these changes Jul 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) July 26, 2023 16:00
RANJEETJ06
RANJEETJ06 commented Jul 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@RANJEETJ06 RANJEETJ06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java convenction changes

debasishbsws
debasishbsws approved these changes Jul 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@debasishbsws debasishbsws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good Thanks for you contribution.

@siriak siriak merged commit cc9afea into TheAlgorithms:master Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siriak siriak siriak approved these changes

@debasishbsws debasishbsws debasishbsws approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@albina-astr albina-astr Awaiting requested review from albina-astr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RANJEETJ06 @siriak @debasishbsws