fix(upgrade): allow for downgraded components to work with component-router #50871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…router In the past, we had an implementation of the "Angular 2" router that also worked with AngularJS. Published as `@angular/router`. We continued to expose that router implementation in G3 and some applications still use it. Now, when upgrading, they are seeing issues where the router throws because it cannot find a route config/ or `$canActivate` on the controller- simply because there is no `controller` function for downgraded components. We can fix this and unblock the update by simply ensuring a controller function is defined.
devversion
added
the
merge: caretaker note
|
Caretaker note: G3 failures are unrelated to this change. |
devversion
added
action: review
jessicajaniuk
approved these changes
Jun 28, 2023
jessicajaniuk
added
action: merge
|
This PR was merged into the repository by commit a19a87d. |
alxhub
pushed a commit
that referenced
this pull request
Jun 30, 2023
…router (#50871) In the past, we had an implementation of the "Angular 2" router that also worked with AngularJS. Published as `@angular/router`. We continued to expose that router implementation in G3 and some applications still use it. Now, when upgrading, they are seeing issues where the router throws because it cannot find a route config/ or `$canActivate` on the controller- simply because there is no `controller` function for downgraded components. We can fix this and unblock the update by simply ensuring a controller function is defined. PR Close #50871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, we had an implementation of the "Angular 2" router that also worked with AngularJS. Published as
@angular/router. We continued to expose that router implementation in G3 and some applications still use it. Now, when upgrading, they are seeing issues where the router throws because it cannot find a route config/ or$canActivateon the controller- simply because there is nocontrollerfunction for downgraded components.We can fix this and unblock the update by simply ensuring a controller function is defined.
Context: https://critique.corp.google.com/cl/539971007