Swift: CustomUrlSchemes test enhancements and minor model improvement #13756
+119
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for the
TaintInheritingContentdefined inCustomUrlSchemes.qll.Add one case I think was missing -
NSUserActivity.referrerURL. @atorralba do you agree with this change or was it left our for a reason?More significantly, these tests draw attention to the fact we don't model Swift
Sets properly yet. This will probably come after array and dictionary improvements but we need to get around to it.