C++: ignore iterators that are their own value type#13445
Closed
rdmarsh2 wants to merge 3 commits intogithub:mainfrom
Closed
C++: ignore iterators that are their own value type#13445rdmarsh2 wants to merge 3 commits intogithub:mainfrom
rdmarsh2 wants to merge 3 commits intogithub:mainfrom
Conversation
Contributor
Author
|
cc @bdrodes who originally reported this |
Contributor
|
This will need some source file formatting and a DCA experiment. A test case would also be appreciated. |
rdmarsh2
force-pushed
the
rdmarsh2/cpp/ignore-self-iterators
branch
from
bdb5e5d to
6d2418b
Compare
Contributor
|
Hmmm... The comment added here seems relevant: I wonder if there's a better fix somewhere lurking here 🤔 |
Contributor
|
I've opened up an alternative fix that doesn't limit our iterator model: #13515. |
Contributor
Author
|
Closing in favor of #13515 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a rare case where IR-based data flow won't have appropriate edges for these types.