Skip to content

port cli to clap 4.0#4445

Closed
burrbull wants to merge 4 commits into
RustPython:mainfrom
burrbull:clap4
Closed

port cli to clap 4.0#4445
burrbull wants to merge 4 commits into
RustPython:mainfrom
burrbull:clap4

Conversation

@burrbull
Copy link
Copy Markdown
Contributor

No description provided.

@fanninpm
Copy link
Copy Markdown
Contributor

Similar in spirit to #3512

@fanninpm
Copy link
Copy Markdown
Contributor

I believe you can use the following command to test your changes locally:

# this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_whatever" (usually located at `Lib/test/test_whatever.py`)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v test_whatever

For a list of all resources and more command-line options, you can execute cargo run --release --features ssl,jit -- -m test -h.

@burrbull
Copy link
Copy Markdown
Contributor Author

Looks like allow_hyphen_values on settings breaks parsing of command line.

@fanninpm
Copy link
Copy Markdown
Contributor

That WASI failure seems to be unrelated.

@fanninpm
Copy link
Copy Markdown
Contributor

fanninpm commented Jan 13, 2023

If you aren't able to figure out why test_quopri.py is failing, asking @epage for help might be a good idea.

Related: clap-rs/clap#3903

@burrbull
Copy link
Copy Markdown
Contributor Author

If you aren't able to figure out why test_quopri.py is failing, asking @epage for help might be a good idea.

Ok. How can I run only this one test?

@fanninpm
Copy link
Copy Markdown
Contributor

fanninpm commented Jan 13, 2023

Ok. How can I run only this one test?

I believe you can use the following command to test your changes locally:

# this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_quopri" (located at `Lib/test/test_quopri.py`)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v test_quopri

For a list of all resources and more command-line options, you can execute cargo run --release --features ssl,jit -- -m test -h.

@youknowone
Copy link
Copy Markdown
Member

clap 4.1 is also out recently

@burrbull burrbull marked this pull request as draft January 14, 2023 08:53
@JamesClarke7283
Copy link
Copy Markdown
Contributor

Any updates on this? is it going to be merged soon or shall i make a PR based on this one?

@burrbull
Copy link
Copy Markdown
Contributor Author

Any updates on this? is it going to be merged soon or shall i make a PR based on this one?

Please, make a new one. I'll close this PR in favor of yours.

@youknowone youknowone mentioned this pull request Sep 24, 2024
@arihant2math
Copy link
Copy Markdown
Contributor

We use lexopt now, so I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants