Skip to content

Added constructor for Settings called with_path#4994

Merged
DimitrisJim merged 1 commit into
RustPython:mainfrom
LucaSforza:main
Jun 10, 2023
Merged

Added constructor for Settings called with_path#4994
DimitrisJim merged 1 commit into
RustPython:mainfrom
LucaSforza:main

Conversation

@LucaSforza

Copy link
Copy Markdown
Contributor

Part of the solution for #4988

@LucaSforza

LucaSforza commented Jun 7, 2023

Copy link
Copy Markdown
Contributor Author

I am also interested in solving the other points to complete the tasks.
But I can't find where to find the error message.
Can you give me a hint so I can do another PR?
(Sorry if this is a stupid question)

@youknowone

Copy link
Copy Markdown
Member

Thank you for contributing!
The error is in fn import_encodings in vm/src/vm/mod.rs

@DimitrisJim DimitrisJim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DimitrisJim DimitrisJim merged commit 0f2ea6a into RustPython:main Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants