Codecov Report

Merging #606 into master will decrease coverage by 0.1%.
The diff coverage is 38.61%.

@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage    41.2%   41.09%   -0.11%     
==========================================
  Files          75       75              
  Lines       17094    17125      +31     
  Branches     4543     4527      -16     
==========================================
- Hits         7043     7038       -5     
- Misses       8014     8048      +34     
- Partials     2037     2039       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d278fb8...1d1a931. Read the comment docs.

With this patch applied:

>>>>> a = 1
>>>>> a.asdf = 4
thread 'main' panicked at 'not yet implemented: set_attr unimplemented for: [PyObj int 1]', vm/src/pyobject.rs:690:13

CPython:

>>> a = 5
>>> a.asdf = 4
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'int' object has no attribute 'asdf'
>>> setattr(a, 'asdf', 4)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'int' object has no attribute 'asdf'

This looks good to me! Please resolve the conflict, so we can merge it.

I'm leaning towards the parent payload approach as suggested in chat. I'm planning on opening a separate PR for that so we can compare / contrast.

It keeps the struct smaller for the vast majority of items that don't have a attributes and payload, and I think it's simple to get the parent payload to extract transparently.