Skip to content

Copilot: Add Vim to docs to make it clear it supports both Vim/Neovim#24625

Merged
jules-p merged 2 commits intogithub:mainfrom
ychin:add-vim-to-copilot-docs
Jun 13, 2023
Merged

Copilot: Add Vim to docs to make it clear it supports both Vim/Neovim#24625
jules-p merged 2 commits intogithub:mainfrom
ychin:add-vim-to-copilot-docs

Conversation

@ychin
Copy link
Copy Markdown
Contributor

@ychin ychin commented Mar 23, 2023 •
edited
Loading

Why:

The repository for Copilot (Neo)Vim plugin was updated to support Vim a while ago. Update the docs to reflect that.

Repository link: https://github.com/github/copilot.vim

Closes: #24624

What's being changed (if available, include any code snippets, screenshots, or gifs):

I didn't rename the files for now, as it didn't seem important enough. Turned out I need to rename the files to match the titles to pass tests. Ran script/reconcile-filenames-with-ids.js to rename the files.

Just changed the title and texts ("Neovim" → "Vim/Neovim"), and added Vim-specific information (mininum version and correct installation procedures pulled from the repo's page).

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link
Copy Markdown

welcome bot commented Mar 23, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 23, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 23, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
copilot/configuring-github-copilot/configuring-github-copilot-in-your-environment.md fpt
ghec
 fpt
ghec
copilot/getting-started-with-github-copilot.md fpt
ghec
 fpt
ghec
copilot/overview-of-github-copilot/about-github-copilot-for-individuals.md fpt
ghec
 fpt
ghec
copilot/troubleshooting-github-copilot/troubleshooting-github-copilot-in-your-environment.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@AS0820075980

This comment was marked as spam.

Sign in to view
@AS0820075980

This comment was marked as spam.

Sign in to view
@ychin ychin force-pushed the add-vim-to-copilot-docs branch 2 times, most recently from 39e6bbc to 4040358 Compare March 23, 2023 12:00
@ychin
Copy link
Copy Markdown
Contributor Author

ychin commented Mar 23, 2023

Ok, tests are passing now. Had to rename the files due to a title change hence slightly more files than I was hoping for, but the commits are separate to make it easier to see what changed.

@AS0820075980

This comment was marked as spam.

Sign in to view
@cmwilson21
Copy link
Copy Markdown
Contributor

cmwilson21 commented Mar 23, 2023

@ychin Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review copilot Content related to GitHub Copilot and removed triage Do not begin working on this issue until triaged by the team labels Mar 23, 2023
@ychin
Copy link
Copy Markdown
Contributor Author

ychin commented Apr 9, 2023 •
edited
Loading

Hi! I'm curious if there is a timeline for review? I'm now getting merge conflicts. I can resolve them but just wanted to see if there will be a reviewer scheduled to take a look. Thanks.

Edit: I have rebased and resolved the conflicts (since the page organizations have changed since I made the PR).

@cmwilson21
Copy link
Copy Markdown
Contributor

cmwilson21 commented Apr 19, 2023

@ychin Thanks for checking in on this. We are working through our backlog, so we appreciate your patience ❤️

Someone will review it soon! 👍

@ychin ychin force-pushed the add-vim-to-copilot-docs branch from 4040358 to db31815 Compare April 22, 2023 11:37
@ychin ychin requested a review from a team as a code owner April 22, 2023 11:37
@ychin ychin force-pushed the add-vim-to-copilot-docs branch from db31815 to e97b208 Compare April 22, 2023 12:03
hectorsector
hectorsector approved these changes Apr 24, 2023
View reviewed changes
Comment thread lib/all-tools.js Outdated
Copy link
Copy Markdown
Contributor

@hectorsector hectorsector Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're good on the addition of Vim/Neovim as a tool for the picker from an Engineering POV. However, I think we'll still need to get a review on the Copilot-specific content changes @cmwilson21

Copy link
Copy Markdown
Contributor

@hectorsector hectorsector Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for getting this opened @ychin!

Copy link
Copy Markdown
Contributor Author

@ychin ychin May 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing. I'm not really sure who's responsibility it is to do that? Should I ping someone to do so or someone on your team will do so?

Also poking @tpope who's the actual author of the plugin (https://github.com/github/copilot.vim) in question, since this PR has been sitting for a while.

@ychin
Copilot: Add Vim to docs to make it clear it supports both Vim/Neovim
087e26b 
The repository for Copilot (Neo)Vim plugin was updated to support Vim a
while ago. Update the docs to reflect that.
@ychin
Copy link
Copy Markdown
Contributor Author

ychin commented May 15, 2023 •
edited
Loading

@cmwilson21 Per the comment above, I think I still need someone from Copilot to take a look per @hectorsector 's comment?

@ychin ychin force-pushed the add-vim-to-copilot-docs branch from e97b208 to 087e26b Compare May 15, 2023 08:07
@cmwilson21
Copy link
Copy Markdown
Contributor

cmwilson21 commented May 26, 2023

@ychin Thanks for checking in! This PR is on the board and waiting for review. We appreciate your patience as we work through some of our backlog. Someone will have eyes on it soon! 💖

jules-p
jules-p approved these changes Jun 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jules-p jules-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ychin 👋 thank you for opening this PR, it looks great ✨ I'll get these changes merged for you.

@jules-p jules-p added this pull request to the merge queue Jun 13, 2023
Merged via the queue into github:main with commit 92897b0 Jun 13, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 13, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@ychin ychin deleted the add-vim-to-copilot-docs branch June 13, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hectorsector hectorsector hectorsector approved these changes

@jules-p jules-p jules-p approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team copilot Content related to GitHub Copilot waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Copilot Neovim docs to include Vim as well

5 participants

@ychin @AS0820075980 @cmwilson21 @hectorsector @jules-p