Skip to content

fix: Add back the fixed CVE-2007-4559 Patch changes#4539

Merged
hnnasit merged 6 commits intodevelopfrom
revert-4535-revert-4499-develop
Jan 10, 2023
Merged

fix: Add back the fixed CVE-2007-4559 Patch changes#4539
hnnasit merged 6 commits intodevelopfrom
revert-4535-revert-4499-develop

Conversation

@hnnasit
Copy link
Contributor

@hnnasit hnnasit commented Jan 5, 2023

Reverts #4535

CVE-2007-4559 Patch changes were reverted as the build integration tests were failing due to a bug. This PR fixes the bug and adds back the reverted changes. The issue was input to extract_tarfile was not a str file path.

@hnnasit hnnasit marked this pull request as ready for review January 5, 2023 23:54
@hnnasit hnnasit requested a review from a team as a code owner January 5, 2023 23:54
@hnnasit hnnasit requested review from mildaniel and moelasmar January 5, 2023 23:54
@hnnasit hnnasit enabled auto-merge (squash) January 10, 2023 18:55
@hnnasit hnnasit merged commit f0e5d85 into develop Jan 10, 2023
hnnasit added a commit that referenced this pull request Jan 11, 2023
sriram-mv pushed a commit that referenced this pull request Jan 11, 2023
hnnasit added a commit that referenced this pull request Jan 16, 2023
hnnasit added a commit that referenced this pull request Jan 20, 2023
 Patch changes (#4580)

* Revert "Revert "fix: Add back the fixed CVE-2007-4559 Patch changes (#4539)" (#4560)"

This reverts commit 6aab7de.

* Updated extract_tarfile to include fileobj as input parameter as well

* Added functional tests for file_obj kw arg
mildaniel pushed a commit to mildaniel/aws-sam-cli that referenced this pull request Jan 26, 2023
 Patch changes (aws#4580)

* Revert "Revert "fix: Add back the fixed CVE-2007-4559 Patch changes (aws#4539)" (aws#4560)"

This reverts commit 6aab7de.

* Updated extract_tarfile to include fileobj as input parameter as well

* Added functional tests for file_obj kw arg
@disconnect3d
Copy link

Hey, @hnnasit, @mildaniel, @sriram-mv just a heads up that this fix for path traversal in tar.extractall is insufficient. Here you can read more information about it: python/cpython#74453 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants