Skip to content

Update sudo-mode.md#25140

Merged
isaacmbrown merged 6 commits into
github:mainfrom
adamrr724:patch-7
Jul 12, 2023
Merged

Update sudo-mode.md#25140
isaacmbrown merged 6 commits into
github:mainfrom
adamrr724:patch-7

Conversation

@adamrr724
Copy link
Copy Markdown
Contributor

@adamrr724 adamrr724 commented Apr 20, 2023 •
edited
Loading

Why: Sudo Mode session timeout should be updated to explicitly state the session length.

Closes: #25141

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Apr 20, 2023
@adamrr724
Copy link
Copy Markdown
Contributor Author

adamrr724 commented Apr 20, 2023

updating this documentation based on this conversation with engineering: https://github.com/github/authnd/issues/1895#issuecomment-1516968032

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 20, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/keeping-your-account-and-data-secure/sudo-mode.md fpt
ghec
ghes@ 3.9 3.8 3.7 3.6 3.5
fpt
ghec
ghes@ 3.9 3.8 3.7 3.6 3.5

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Copy Markdown
Contributor

cmwilson21 commented Apr 21, 2023

👋 @adamrr724 Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Apr 21, 2023
isaacmbrown
isaacmbrown reviewed Apr 26, 2023
View reviewed changes
Comment thread content/authentication/keeping-your-account-and-data-secure/sudo-mode.md Outdated
isaacmbrown
isaacmbrown reviewed Apr 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@isaacmbrown isaacmbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adamrr724, thanks for submitting the PR! I just left a small styling suggestion

I saw the discussion in the linked issue is around the timeout period in GHES. I was wondering if we know for sure that the period is the same across GHES and dotcom, or whether you'd like to version this change to only appear in the GHES version of the docs?

@isaacmbrown
Copy link
Copy Markdown
Contributor

isaacmbrown commented May 15, 2023

Hi @adamrr724, just checking whether you're still planning to get this merged?

@adamrr724 @isaacmbrown
Update content/authentication/keeping-your-account-and-data-secure/su…
ec4892d 
…do-mode.md

Co-authored-by: Isaac Brown <101839405+isaacmbrown@users.noreply.github.com>
@adamrr724
Copy link
Copy Markdown
Contributor Author

adamrr724 commented May 16, 2023

Hey there, sorry missed this @isaacmbrown -- this is specifically for GHES, so let's only add it to the GHES docs!

isaacmbrown
isaacmbrown reviewed May 17, 2023
View reviewed changes
Comment thread content/authentication/keeping-your-account-and-data-secure/sudo-mode.md
hpsin
hpsin reviewed Jun 29, 2023
View reviewed changes
Comment thread content/authentication/keeping-your-account-and-data-secure/sudo-mode.md Outdated
@isaacmbrown @hpsin
Update content/authentication/keeping-your-account-and-data-secure/su…
1a59ebc 
…do-mode.md

Co-authored-by: Hirsch Singhal <1666363+hpsin@users.noreply.github.com>
isaacmbrown
isaacmbrown approved these changes Jul 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@isaacmbrown isaacmbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion all! Sounds like we didn't need the versioning after all. Let me get this merged 🚀

@isaacmbrown isaacmbrown enabled auto-merge July 11, 2023 08:40
@isaacmbrown isaacmbrown added this pull request to the merge queue Jul 12, 2023
Merged via the queue into github:main with commit 8d1d7c9 Jul 12, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 12, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaacmbrown isaacmbrown isaacmbrown approved these changes

+1 more reviewer

@hpsin hpsin hpsin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Sudo Mode documentation to include session timeout length

4 participants

@adamrr724 @cmwilson21 @isaacmbrown @hpsin