Specify scope of default environment variables#24896
Conversation
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
236d268 to
f7addc4
Compare
|
@valentin-krasontovitsch Thank you for opening a PR and linking it to your issue! ✨ I'll get this triaged for review! ⚡ |
f7addc4 to
6002944
Compare
6002944 to
5bce077
Compare
|
four months for a simple, small docs update. I have my own project that I'm woefully neglecting, so I understand this can happen, but that one has just one maintainer, and is free-time based 😅 |
|
@valentin-krasontovitsch Thanks for checking in on this. It is up on the board for review 👍 We appreciate your patience as we are working through our backlog 💖 |
|
Of course, thank you for your response, and godspeed 🌈 |
|
Hey @valentin-krasontovitsch, thank you so much for your patience with us as we work through our backlog. 🙇♀️ I do see how it would be confusing for users to know how to use default environment variables in workflows with the way the docs are currently written. There is a note underneath the table of default environment variables that says:
What do you think of this idea: We could move that out of the note and into its own paragraph after the first sentence in the introduction. We could also add a sentence before it so that we say something along the lines of:
Would that make things more clear in this doc? Let me know! Thank you for helping to improve GitHub's docs! ⚡ |
|
yes i think that would definitely help! thanks for the much better suggestion : ) should i change this PR to reflect your suggestions, or close this one and leave it to you / somebody else to create a new PR? |
|
That's awesome. 😃 @valentin-krasontovitsch if you want to update this PR, then I can accept your changes and get them merged! |
To increase visibility for how to access default environment variables, we move the corresponding note to the top of the relevant section and add some more detail.
5bce077 to
a32090c
Compare
|
it is done ^^ let me know if the new diff is OK, and if the commit message is up to par. |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
It is not obvious that default environment variables will not be available in the
envcontext. We add a note to that regard.Why:
Closes: #24895
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: