Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript: Add new queries for Javascript actions #12781

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

R3x
Copy link

@R3x R3x commented Apr 6, 2023

Added 3 Queries, that track flows from -

  1. Action Input to Sinks
  2. Action Github Context to Sinks
  3. Action Environment to Sinks

@R3x R3x requested a review from a team as a code owner April 6, 2023 14:06
@github-actions github-actions bot added the JS label Apr 6, 2023
@calumgrant calumgrant requested a review from asgerf April 6, 2023 14:08
@R3x
Copy link
Author

R3x commented Apr 6, 2023

@kevinbackhouse @JarLob - I have added the sinks that are of higher priority here. During the analysis - we also marked some lower-priority sinks (things such as fs.write etc). Which basically provides primitives such as an arbitrary file write - but not as severe as the ones here. Do you prefer that I add them as well?

@kevinbackhouse
Copy link
Contributor

@kevinbackhouse @JarLob - I have added the sinks that are of higher priority here. During the analysis - we also marked some lower-priority sinks (things such as fs.write etc). Which basically provides primitives such as an arbitrary file write - but not as severe as the ones here. Do you prefer that I add them as well?

I think it's better to start with just the high-priority ones, so that you have a lower false-positive rate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants