monaco-editor-3626: Ensure brackets are highlighted in languages like 'json' #176084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
jessebluemr
force-pushed
the
monaco-editor-issue-3626
branch
from
46e7582 to
1262104
Compare
jessebluemr
force-pushed
the
monaco-editor-issue-3626
branch
from
1262104 to
94fb920
Compare
Kaparrs
previously approved these changes
Mar 6, 2023
jessebluemr
force-pushed
the
monaco-editor-issue-3626
branch
from
94fb920 to
95271e7
Compare
…mask of language metadata to ensure balanced brackets are searched
jessebluemr
force-pushed
the
monaco-editor-issue-3626
branch
from
95271e7 to
34bcbc3
Compare
hediet
approved these changes
Mar 16, 2023
bpasero
approved these changes
Mar 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to the Bug monaco-editor 3626 reported to the monaco-editor project.
The fix makes sure that languages like
jsontokenized in the browser via the TokenizationSupportAdapter instandaloneLanguages.tswill support highlighting matching brackets.The MetadataConsts.BALANCED_BRACKETS_MASK flag is added to the bitmask of the language metadata, like in monarchLexer.ts.