Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] bpo-42972: Fully implement GC protocol for re types (GH-26368) #26411

Closed
wants to merge 1 commit into from
Closed

[3.10] bpo-42972: Fully implement GC protocol for re types (GH-26368) #26411

wants to merge 1 commit into from
+81 −19

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 27, 2021 •
edited by bedevere-bot

(cherry picked from commit fba42d1)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue42972
@erlend-aasland @miss-islington
bpo-42972: Fully implement GC protocol for re types (pythonGH-26368)
e269fa1 
(cherry picked from commit fba42d1)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 27, 2021

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request May 27, 2021
Merged
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 27, 2021

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .

vstinner
vstinner approved these changes May 27, 2021
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 27, 2021

@erlend-aasland and @vstinner: Status check is done, and it's a failure ❌ .

@vstinner
Copy link
Member

@vstinner vstinner commented May 27, 2021

Tests / Windows (x64) (pull_request) Failing

It failed because of: https://bugs.python.org/issue44252#msg394581

I re-run the job.

@vstinner vstinner closed this May 27, 2021
@miss-islington miss-islington deleted the backport-fba42d1-3.10 branch May 27, 2021
@vstinner
Copy link
Member

@vstinner vstinner commented May 27, 2021

Problem 2: I had to cancel the Ubuntu job after 1 hour since downloading the ccache never completed.

Problem 3: I cannot re-run all jobs, the GitHub UI only offers me [cancel workflow] choice. I closed the PR, I will recreate it instead. Let's hope that https://bugs.python.org/issue44252#msg394581 doesn't occur again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees
No one assigned
Labels
awaiting merge CLA signed skip news
Projects
None yet
Milestone
No milestone
5 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot @erlend-aasland