Skip to content

Update removing-sensitive-data-from-a-repository.md #24551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 13, 2023
Merged

Update removing-sensitive-data-from-a-repository.md #24551

merged 5 commits into from
Apr 13, 2023

Conversation

jjkennedy3
Copy link
Contributor

@jjkennedy3 jjkennedy3 commented Mar 20, 2023 •
edited
Loading

Adding a note that if the file is identified as a binary file the file must be removed.

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@jjkennedy3
Update removing-sensitive-data-from-a-repository.md
bdbe750 
Adding a note that if the file is identified as a binary file the file must be removed.
@welcome
Copy link

welcome bot commented Mar 20, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 20, 2023
chiph
chiph previously approved these changes Mar 20, 2023
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/keeping-your-account-and-data-secure/removing-sensitive-data-from-a-repository.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
 fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

👋 @jjkennedy3 Thanks so much for opening a PR! I'll get this triaged for writer review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Mar 21, 2023
hubwriter
hubwriter reviewed Mar 30, 2023
View reviewed changes
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjkennedy3 - Many thanks for raising this PR. 👍

I've suggested a small change to the wording of the note. Let me know what you think and we can get this merged.

Thanks again

@jjkennedy3 @hubwriter
Update content/authentication/keeping-your-account-and-data-secure/re…
1cf746f 
…moving-sensitive-data-from-a-repository.md


commit suggestions from writer review

Co-authored-by: hubwriter <hubwriter@github.com>
@hubwriter
Copy link
Contributor

I'm going to get this merged.
🚢

@hubwriter hubwriter enabled auto-merge April 13, 2023 11:02
@hubwriter hubwriter added this pull request to the merge queue Apr 13, 2023
Merged via the queue into github:main with commit 5c6511d Apr 13, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiph chiph chiph approved these changes

@hubwriter hubwriter hubwriter approved these changes

Assignees
No one assigned
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjkennedy3 @cmwilson21 @hubwriter @chiph