Skip to content

Fix missing heading in Octernships TOS#24416

Merged
mchammer01 merged 3 commits into
github:mainfrom
ynshung:patch-1
Mar 22, 2023
Merged

Fix missing heading in Octernships TOS#24416
mchammer01 merged 3 commits into
github:mainfrom
ynshung:patch-1

Conversation

@ynshung
Copy link
Copy Markdown
Contributor

@ynshung ynshung commented Mar 13, 2023

Why:

Missing heading in the markdown of GitHub Octernships Terms of Service for section 2.2

What's being changed (if available, include any code snippets, screenshots, or gifs):

Added the missing heading

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@ynshung ynshung requested a review from a team as a code owner March 13, 2023 10:38
@welcome
Copy link
Copy Markdown

welcome Bot commented Mar 13, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Mar 13, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 13, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
site-policy/privacy-policies/github-octernships-terms-of-service.md fpt
 fpt

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Copy Markdown
Contributor

cmwilson21 commented Mar 15, 2023

@ynshung Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team site policy Content related to site policy waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Mar 15, 2023
@mchammer01 mchammer01 self-requested a review March 16, 2023 08:15
mchammer01
mchammer01 previously approved these changes Mar 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ynshung - thanks for fixing this ✨
Added a small suggestion that has nothing to do with your fix. Will apply it and then merge your PR. Thanks again for helping us make our docs better 🥇

Comment thread content/site-policy/privacy-policies/github-octernships-terms-of-service.md Outdated
@mchammer01
Copy link
Copy Markdown
Contributor

mchammer01 commented Mar 16, 2023

Oops, I won't be able to merge this without the approval from the @github/site-policy-admins folks 🙏🏻

@mchammer01 mchammer01 enabled auto-merge March 22, 2023 14:51
mchammer01
mchammer01 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@mchammer01 mchammer01 merged commit 604d5a5 into github:main Mar 22, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 22, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khxu khxu khxu approved these changes

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team site policy Content related to site policy waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ynshung @cmwilson21 @mchammer01 @khxu