Skip to content

Make examples consistent#24272

Merged
rachaelrenk merged 2 commits into
github:mainfrom
AlekSi:patch-1
May 3, 2023
Merged

Make examples consistent#24272
rachaelrenk merged 2 commits into
github:mainfrom
AlekSi:patch-1

Conversation

@AlekSi
Copy link
Copy Markdown
Contributor

@AlekSi AlekSi commented Mar 3, 2023 •
edited
Loading

Why:

Example uses different paths.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Sync paths with the workflow above.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@AlekSi
Make examples consistent
56f6641 
Sync paths with the workflow above.
@welcome
Copy link
Copy Markdown

welcome Bot commented Mar 3, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Mar 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 3, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/troubleshooting-required-status-checks.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
 fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Copy Markdown
Contributor

cmwilson21 commented Mar 3, 2023

@AlekSi Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review repositories Content related to repositories and removed triage Do not begin working on this issue until triaged by the team labels Mar 3, 2023
rachaelrenk
rachaelrenk approved these changes Apr 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@rachaelrenk rachaelrenk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlekSi 👋 Your content changes look good to me. Can you resolve the merge conflicts on your fork? Once those are resolved, this is approved and we can get it merged. Thanks! 🛸

@AlekSi
Copy link
Copy Markdown
Contributor Author

AlekSi commented Apr 30, 2023

@rachaelrenk done, PTAL

@AlekSi AlekSi requested a review from rachaelrenk April 30, 2023 10:37
rachaelrenk
rachaelrenk approved these changes May 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@rachaelrenk rachaelrenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'll get this merged. ✨ 🛸

@rachaelrenk rachaelrenk added this pull request to the merge queue May 3, 2023
Merged via the queue into github:main with commit d76e9e7 May 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@AlekSi AlekSi deleted the patch-1 branch May 8, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rachaelrenk rachaelrenk rachaelrenk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team repositories Content related to repositories waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlekSi @cmwilson21 @rachaelrenk