Python: Use _one_ parameter position for normal parameters #12468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That can be used with both positional and keyword arguments. Before we provided BOTH a positional and keyword parameter position, which broke some assumptions in the dataflow library.
Having these tests show all the synthetic nodes from flow-summaries seems like it will become very annoying once we start expanding the amount of flow summaries.
RasmusWL
commented
Mar 16, 2023
Comment on lines
+45
to
+54
| TNormalParameterPosition(int index, string name) { | ||
| exists(Function f, Parameter p, int indexOffset | | ||
| p = f.getArg(index + indexOffset) and | ||
| p = f.getArgByName(name) and | ||
| indexOffset = any(DataFlowFunction dff | dff.getScope() = f).positionalOffset() and | ||
| // for things that will be considered a self parameter, we do not need to create a | ||
| // parameter position | ||
| index >= 0 | ||
| ) | ||
| } or |
Member
Author
There was a problem hiding this comment.
Maybe I should have explained better that for the method definition below, we need to take care for the self parameter, so want to have TNormalParameterPosition(0, "arg").
class Foo:
def meth(self, arg): pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That can be used with both positional and keyword arguments. Before we provided BOTH a positional and keyword parameter position, which broke some assumptions in the dataflow library.
(Created as draft to see effect before requesting review)