Skip to content

delete old deprecations#12345

Merged
erik-krogh merged 4 commits into
github:mainfrom
erik-krogh:delOldDeps
Mar 13, 2023
Merged

delete old deprecations#12345
erik-krogh merged 4 commits into
github:mainfrom
erik-krogh:delOldDeps

Conversation

@erik-krogh
Copy link
Copy Markdown
Contributor

@erik-krogh erik-krogh commented Mar 1, 2023 •
edited
Loading

Used the results from ql/outdated-deprecation.

@erik-krogh erik-krogh marked this pull request as ready for review March 3, 2023 08:23
@erik-krogh erik-krogh requested review from a team as code owners March 3, 2023 08:23
@erik-krogh erik-krogh requested review from hmac and removed request for a team March 3, 2023 08:23
aschackmull
aschackmull previously approved these changes Mar 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 👍 🎉

@jketema
Copy link
Copy Markdown
Contributor

jketema commented Mar 3, 2023 •
edited
Loading

The query seems to miss stuff, e.g., cpp/ql/src/external/CodeDuplication.qll, which has things in it that have been deprecated for a year. Unless there's some use of those deprecated predicates/classes I don't understand. Or is the cut-off more than a year?

jketema
jketema previously approved these changes Mar 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ 👍

@atorralba
Copy link
Copy Markdown
Contributor

atorralba commented Mar 3, 2023

Or is the cut-off more than a year?

The cut-off seems to be 14 months:

codeql/ql/ql/src/queries/reports/OutdatedDeprecations.ql

Line 45 in 1a19909

select d, "This deprecation is over 14 months old."

@jketema
Copy link
Copy Markdown
Contributor

jketema commented Mar 3, 2023

Ah, right, then hopefully the code duplication stuff should be removed in the next round.

asgerf
asgerf previously approved these changes Mar 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asgerf asgerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS 👍

tausbn
tausbn previously approved these changes Mar 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 👍

@geoffw0
Copy link
Copy Markdown
Contributor

geoffw0 commented Mar 3, 2023

I appreciate the change notes on this, good reminder for any customers still using deprecated stuff.

michaelnebel
michaelnebel previously approved these changes Mar 3, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# 👍

Comment thread csharp/ql/lib/change-notes/2023-03-03-delete-deps.md Outdated
category: minorAnalysis
---
* Deleted the deprecated `getPath` and `getFolder` predicates from the `XmlFile` class.
* Deleted the deprecated `getAssertionIndex`, `getAssertedParameter`, and `getAssertedParameter` predicates from the `AssertMethod` class.
Copy link
Copy Markdown
Contributor

@michaelnebel michaelnebel Mar 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: getAssertedParameter is listed twice.

@erik-krogh erik-krogh dismissed stale reviews from michaelnebel and tausbn via b875d30 March 3, 2023 14:55
@erik-krogh erik-krogh dismissed stale reviews from asgerf, jketema, and aschackmull via b875d30 March 3, 2023 14:55
michaelnebel
michaelnebel approved these changes Mar 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# 👍

hvitved
hvitved approved these changes Mar 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# / Ruby 👍

hmac
hmac approved these changes Mar 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@hmac hmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruby 👍

@erik-krogh erik-krogh requested review from a team as code owners March 13, 2023 10:00
@erik-krogh
Copy link
Copy Markdown
Contributor Author

erik-krogh commented Mar 13, 2023

Did a merge with main to fix a conflict.

@erik-krogh erik-krogh merged commit 060c37b into github:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hvitved hvitved hvitved approved these changes

@michaelnebel michaelnebel michaelnebel approved these changes

@geoffw0 geoffw0 geoffw0 approved these changes

@asgerf asgerf asgerf left review comments

@tausbn tausbn tausbn left review comments

@aschackmull aschackmull aschackmull left review comments

@jketema jketema jketema left review comments

+1 more reviewer

@hmac hmac hmac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C# C++ documentation Java JS Python Ruby

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@erik-krogh @jketema @atorralba @geoffw0 @hmac @asgerf @tausbn @hvitved @michaelnebel @aschackmull