docs(docs-infra): improve docs for styling precedence and class binding.#49435
Closed
avmaxim wants to merge 1 commit into
Closed
docs(docs-infra): improve docs for styling precedence and class binding.#49435avmaxim wants to merge 1 commit into
avmaxim wants to merge 1 commit into
Conversation
This PR removes confusing "Styling Precedence" section from the "Class Binding" docs and adds more clarification on it in the following sections: "Binding to multiple styles" and "Binding to multiple CSS classes" which already have references to the "Style Precedence" docs, so there is no need to duplicate it. Fixes angular#48522.
Closed
Contributor
Author
|
@alan-agius4 @bob-watson Please take a look based on this discussion - #48522 (comment) |
jessicajaniuk
added
action: review
Contributor
|
@avmaxim Can you rebase to latest? That would likely resolve the CI issues. |
Member
|
Thnx for the PR @avmaxim - looking at it I don't think that "These rules specify an order for which style-related bindings have priority" sentence adds much clarification as "precedence" implies "priority", IMO. I'm going to close this PR based on the above but we can sure iterate on a different version of the wording. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the confusing section - ## Style Precendece - from Class and style binding docs and adds more clarification to it in the following sections: ## Binding to multiple styles and ## Binding to multiple CSS classes which already contain references to Style Precedence docs. Hence, there is no need to duplicate it as a separate section.
Fixes #48522.
PR Checklist
Please check if your PR fulfills the following requirements:
N/A: Tests for the changes have been added (for bug fixes / features)PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?