Skip to content

docs(docs-infra): improve docs for @angular/localize package.#49393

Closed
avmaxim wants to merge 1 commit into
angular:mainfrom
avmaxim:docs/angular-localize
Closed

docs(docs-infra): improve docs for @angular/localize package.#49393
avmaxim wants to merge 1 commit into
angular:mainfrom
avmaxim:docs/angular-localize

Conversation

@avmaxim
Copy link
Copy Markdown
Contributor

@avmaxim avmaxim commented Mar 10, 2023 •
edited
Loading

This PR adds missing documentation for @angular/localize package and fixes a tiny one-word typo in the README.md file for @angular/localize schematic.

Fixes #49219.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove Bot requested a review from AndrewKushnir March 10, 2023 15:29
@ngbot ngbot Bot added this to the Backlog milestone Mar 10, 2023
@alan-agius4 alan-agius4 self-requested a review March 10, 2023 15:32
@avmaxim avmaxim mentioned this pull request Mar 10, 2023
Closed
@avmaxim
Copy link
Copy Markdown
Contributor Author

avmaxim commented Mar 10, 2023

@AndrewKushnir @alan-agius4 hi guys, please take a look and LMK if there's anything I need to update before merging. Thanks! Please also review my comments to the corresponding issue - #49219 (comment)

@AndrewKushnir AndrewKushnir requested review from clydin and removed request for alan-agius4 March 10, 2023 18:46
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Mar 10, 2023
AndrewKushnir
AndrewKushnir reviewed Mar 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avmaxim thanks for improving Angular docs! 👍

I've let a couple comments and I'd propose to change the commit message (via git commit --amend) to change "add insufficient docs" to "add missing docs" or "improve docs for ...".

Also added @clydin as a reviewer to see if there is any additional feedback.

Thank you.

Comment thread aio/content/guide/i18n-common-add-package.md Outdated
Comment thread aio/content/guide/i18n-common-add-package.md Outdated
@avmaxim avmaxim force-pushed the docs/angular-localize branch from 265b7c7 to a3df037 Compare March 11, 2023 19:55
@avmaxim avmaxim changed the title docs(docs-infra): add insufficient docs for @angular/localize package. docs(docs-infra): improve docs for @angular/localize package. Mar 12, 2023
alan-agius4
alan-agius4 reviewed Mar 13, 2023
View reviewed changes
Comment thread aio/content/guide/i18n-common-add-package.md Outdated
alan-agius4
alan-agius4 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@AndrewKushnir AndrewKushnir removed the request for review from clydin March 13, 2023 18:14
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 13, 2023
@ngbot
Copy link
Copy Markdown

ngbot Bot commented Mar 13, 2023

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "CircleCI Pipeline" is failing
    pending missing required status "ci/circleci: build"
    pending missing required status "ci/circleci: lint"
    pending missing required status "ci/angular: size"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@avmaxim @AndrewKushnir
docs(docs-infra): improve docs for @angular/localize package.
68b6e66 
This PR adds missing documentation for `@angular/localize` package and fixes a tiny one-word typo in the `README.md` file for `@angular/localize schematic`.

Fixes angular#49219.
@AndrewKushnir AndrewKushnir force-pushed the docs/angular-localize branch from d4ec84b to 68b6e66 Compare March 13, 2023 18:15
@avmaxim
Copy link
Copy Markdown
Contributor Author

avmaxim commented Mar 13, 2023

@AndrewKushnir any ideas on the pipeline issue? seems to be related to the GitHub Actions token permissions

image

@AndrewKushnir AndrewKushnir added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 13, 2023
@AndrewKushnir
Copy link
Copy Markdown
Contributor

AndrewKushnir commented Mar 13, 2023

@josephperrott @devversion could you please help look into the issue with the CI reported in #49393 (comment)? I've restarted the CI after the approval and still see the same problem. Is it somehow caused by the rebase that I've pushed (to restart the CI that didn't run previously)?

@avmaxim
Copy link
Copy Markdown
Contributor Author

avmaxim commented Mar 17, 2023 •
edited
Loading

@josemontespg @devversion hi, once you have time guys, please advise on the issue above, that would be highly appreciated! Or maybe add someone who might help either :) We're only left to merge it properly. Thanks

@devversion
Copy link
Copy Markdown
Member

devversion commented Mar 20, 2023

@avmaxim My understanding is that @josephperrott already looked into it. I will defer to him.

@devversion
Copy link
Copy Markdown
Member

devversion commented Mar 20, 2023

We can move forward with this PR though- it should not be blocking

@devversion devversion added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 20, 2023
@devversion
Copy link
Copy Markdown
Member

devversion commented Mar 20, 2023

Caretaker note: Please ignore the post-approval check. We are fixing this separately and this PR is not blocked on it

@pkozlowski-opensource
Copy link
Copy Markdown
Member

pkozlowski-opensource commented Mar 20, 2023

This PR was merged into the repository by commit d5946bd.

pkozlowski-opensource pushed a commit that referenced this pull request Mar 20, 2023
@avmaxim @pkozlowski-opensource
docs(docs-infra): improve docs for @angular/localize package. (#49393)
0f0c0a9 
This PR adds missing documentation for `@angular/localize` package and fixes a tiny one-word typo in the `README.md` file for `@angular/localize schematic`.

Fixes #49219.

PR Close #49393
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot Bot commented Apr 20, 2023

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Add the localize package page is outdated

5 participants

@avmaxim @AndrewKushnir @devversion @pkozlowski-opensource @alan-agius4