Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make common::repr throw error instead of panic #4520

Merged
merged 7 commits into from Feb 19, 2023
Merged

Make common::repr throw error instead of panic #4520

merged 7 commits into from Feb 19, 2023

Conversation

minhrongcon2000
Copy link
Contributor

A solution for #4511

DimitrisJim
DimitrisJim reviewed Feb 18, 2023
View changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I've left some comments

vm/src/exceptions.rs Outdated Show resolved Hide resolved
common/src/bytes.rs Outdated Show resolved Hide resolved
vm/src/builtins/bytearray.rs Outdated Show resolved Hide resolved
common/src/bytes.rs Outdated Show resolved Hide resolved
youknowone
youknowone requested changes Feb 19, 2023
View changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left a change request about message. Other parts looks good.

vm/src/builtins/bytearray.rs Outdated Show resolved Hide resolved
vm/src/builtins/bytearray.rs Outdated Show resolved Hide resolved
vm/src/exceptions.rs Outdated Show resolved Hide resolved
youknowone
youknowone reviewed Feb 19, 2023
View changes
vm/src/bytesinner.rs Outdated Show resolved Hide resolved
youknowone
youknowone reviewed Feb 19, 2023
View changes
compiler/ast/src/constant.rs Outdated Show resolved Hide resolved
youknowone
youknowone approved these changes Feb 19, 2023
View changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, Thank you!

@youknowone youknowone merged commit 8b7158f into RustPython:main Feb 19, 2023
13 checks passed
@youknowone youknowone added the zls-2023 Tag to track Line OSS Sprint 2023 label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone

@DimitrisJim DimitrisJim

Assignees
No one assigned
Labels
zls-2023 Tag to track Line OSS Sprint 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@minhrongcon2000 @youknowone @DimitrisJim