Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10041 Part1 - Refactor and clean up System APIs #10042

Merged
merged 2 commits into from Feb 4, 2023
Merged

10041 Part1 - Refactor and clean up System APIs #10042

merged 2 commits into from Feb 4, 2023

Conversation

sureshms
Copy link
Contributor

@sureshms sureshms commented Feb 1, 2023

Describe your changes :

See #10041 for more details.

Type of change :

  • Improvement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

@sureshms sureshms requested review from a team as code owners February 1, 2023 01:44
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Feb 1, 2023
@github-actions
Copy link

github-actions bot commented Feb 1, 2023 •
edited

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 51%
 52.81% (18498/35030) 29.39% (7044/23966) 32.7% (2246/6869)

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sureshms sureshms requested a review from a team as a code owner February 3, 2023 17:33
@sureshms sureshms temporarily deployed to test February 3, 2023 18:54 — with GitHub Actions Inactive
@sureshms sureshms temporarily deployed to test February 3, 2023 18:54 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

[OpenMetadata-Platform] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

48.2% 48.2% Coverage
0.0% 0.0% Duplication

@cypress
Copy link

cypress bot commented Feb 3, 2023 •
edited

Passing run #15201 ↗︎

0 224 2 0 Flakiness 0

Details:

Update the config resource endpoint url
Project: openmetadata Commit: e3b98dba76
Status: Passed Duration: 09:34 💡
Started: Feb 3, 2023 9:26 PM Ended: Feb 3, 2023 10:36 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sureshms sureshms temporarily deployed to test February 3, 2023 21:08 — with GitHub Actions Inactive
@sureshms sureshms temporarily deployed to test February 3, 2023 21:08 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@sureshms sureshms mentioned this pull request Feb 4, 2023
Open
@sureshms sureshms merged commit 1990ac5 into main Feb 4, 2023
18 of 22 checks passed
@sureshms sureshms deleted the 10041-part1 branch February 4, 2023 00:25
@sureshms sureshms temporarily deployed to publish February 4, 2023 00:25 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

@akash-jain-10 akash-jain-10 akash-jain-10 left review comments

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sureshms @harshach @akash-jain-10