Skip to content

Add Batch file topic#3568

Merged
smashwilson merged 6 commits into
github:mainfrom
Minionguyjpro:main
Feb 22, 2023
Merged

Add Batch file topic#3568
smashwilson merged 6 commits into
github:mainfrom
Minionguyjpro:main

Conversation

@Minionguyjpro
Copy link
Copy Markdown
Contributor

@Minionguyjpro Minionguyjpro commented Feb 18, 2023

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • My folder contains a *.png image (if applicable) and index.md
  • All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

So people could easily find out that some software is (based on) a batch script, and also find software with it.

Something that does not neatly fit into the binary options above

  • My suggested edits are not about an existing topic or collection, or at least not a single one
  • My suggested edits are not about curating a new topic or collection, or at least not a single one
  • My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@Minionguyjpro Minionguyjpro requested a review from a team as a code owner February 18, 2023 13:55
Copy link
Copy Markdown
Contributor

@smashwilson smashwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good aside from the UEFI topic change that snuck in! If you take that out I'll be happy to merge.

Comment thread topics/uefi/index.md Outdated
created_by: Intel
display_name: UEFI
short_description: UEFI is a publicly available specification that defines a software interface between an operating system and platform firmware.
github_url: https://github.com/Intel
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this unrelated change intentional?

Also I'm not sure it makes sense to link to the entire Intel org in the topic for a spec. Do they have a repo dedicated to UEFI? Otherwise it would be better to leave it off, I think.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was, but how can I also remove this change? Not sure how to do that in GitHub...

@Minionguyjpro
Copy link
Copy Markdown
Contributor Author

I've removed the change. Should be ready now.

Copy link
Copy Markdown
Contributor

@smashwilson smashwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks for contributing! 🙇🏻

@smashwilson smashwilson added this pull request to the merge queue Feb 22, 2023
Merged via the queue into github:main with commit e1aefcc Feb 22, 2023
@rchoulak
Copy link
Copy Markdown

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants