Ensure socket.gethostbyname_ex only returns IPv4 addresses#4529
Merged
DimitrisJim merged 1 commit intoFeb 20, 2023
Conversation
DimitrisJim
approved these changes
Feb 20, 2023
Member
DimitrisJim
left a comment
DimitrisJim
left a comment
There was a problem hiding this comment.
seems to do the trick, thanks for looking into this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gethostbyname_exfunction of thesocketmodule is only supposed to return IPv4 address as per the documentation: https://docs.python.org/3/library/socket.html#socket.gethostbyname_exThis can also be seen in the CPython code: https://github.com/python/cpython/blob/c00faf79438cc7f0d98af2679c695f747e4369a3/Modules/socketmodule.c#L5882
This commit replace
AF_UNSPECwithAF_INETso that only IPv4 are returned. This also fixes the test issue I had in PR #4526 .I don't know if the test will pass on other platforms so I'm opening this PR to see the test results 🙂