Skip to content

Move NumberUtils.qll from Ruby into shared util pack#12169

Merged
hvitved merged 3 commits intogithub:mainfrom
hvitved:util/numbers
Feb 13, 2023
Merged

Move NumberUtils.qll from Ruby into shared util pack#12169
hvitved merged 3 commits intogithub:mainfrom
hvitved:util/numbers

Conversation

@hvitved
Copy link
Copy Markdown
Contributor

@hvitved hvitved commented Feb 13, 2023

These predicates are relevant not just for Ruby.

@github-actions github-actions bot added the Ruby label Feb 13, 2023
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Feb 13, 2023
@hvitved hvitved marked this pull request as ready for review February 13, 2023 15:20
@hvitved hvitved requested a review from a team as a code owner February 13, 2023 15:20
Copy link
Copy Markdown
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. I think I can use this in some regex parsers, where I parse unicode encoded as octals.

I'll check that out after this merged.

LGTM 👍

@hvitved hvitved merged commit 8372ad9 into github:main Feb 13, 2023
@hvitved hvitved deleted the util/numbers branch February 13, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-change-note-required This PR does not need a change note Ruby

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants