wasi: add wasi sock_accept stub #46434
Open
+35
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
mhdawson
removed
the
wasi
mhdawson
added
the
wasi
Refs: nodejs/uvwasi#185 Add stub for sock_accept so that we have stubs for all of the sock methods in wasi_snapshot_preview1. Its a bit awkward as the method was added after the initial definitial of wasi_snapshot-preview1 but I think it should be semver minor at most to add the method. Depends on nodejs/uvwasi#185 being landed in uvwasi first and an updated version of uvwasi that includes that being pulled into Node.js Signed-off-by: Michael Dawson <mdawson@devrus.com>
jasnell
approved these changes
Jan 31, 2023
cjihrig
approved these changes
Jan 31, 2023
| @@ -1234,6 +1234,21 @@ uint32_t WASI::SockShutdown(WASI& wasi, | |||
| return uvwasi_sock_shutdown(&wasi.uvw_, sock, how); | |||
| } | |||
|
|
|||
| uint32_t WASI::SockAccept(WASI& wasi, | |||
There was a problem hiding this comment.
I think the WASI functions are sorted alphabetically in this file. Can you move this?
| @@ -1306,6 +1321,7 @@ static void Initialize(Local<Object> target, | |||
| V(SockRecv, "sock_recv") | |||
| V(SockSend, "sock_send") | |||
| V(SockShutdown, "sock_shutdown") | |||
| V(SockAccept, "sock_accept") | |||
There was a problem hiding this comment.
Same comment about sorting here.
| @@ -142,6 +142,7 @@ class WASI : public BaseObject, | |||
| static uint32_t SockSend( | |||
| WASI&, WasmMemory, uint32_t, uint32_t, uint32_t, uint32_t, uint32_t); | |||
| static uint32_t SockShutdown(WASI&, WasmMemory, uint32_t, uint32_t); | |||
| static uint32_t SockAccept(WASI&, WasmMemory, uint32_t, uint32_t, uint32_t); | |||
There was a problem hiding this comment.
Same comment about sorting.
| int flags = 0; | ||
| int ret = accept(0, NULL, &addrlen); | ||
| assert(ret == -1); | ||
| assert(errno == 58); |
There was a problem hiding this comment.
You should be able to compare against error codes here. [example]
| #include <stdio.h> | ||
|
|
||
| int main(void) { | ||
|
|
There was a problem hiding this comment.
Since this file will need to be updated when there is a full implementation of sock_accept(), could you leave a TODO comment.
Nit: blank line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Refs: nodejs/uvwasi#185
Add stub for sock_accept so that we have stubs
for all of the sock methods in wasi_snapshot_preview1.
Its a bit awkward as the method was added after the
initial definitial of wasi_snapshot-preview1 but I
think it should be semver minor at most to add
the method.
Depends on nodejs/uvwasi#185
being landed in uvwasi first and an updated version
of uvwasi that includes that being pulled into
Node.js
Signed-off-by: Michael Dawson mdawson@devrus.com