feat(install): follow redirects for urls with no path #17449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Jan 23, 2023
kamilogorek
force-pushed
the
install-follow-redirect
branch
from
3803fda
to
4fb81d4
Compare
|
@dsherret I took some time and rewrote it using |
dsherret
approved these changes
Feb 10, 2023
dsherret
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This change makes absolute urls, that contain no path like
deno install https://my-cli.ioto follow redirects and extract the name from it.It allows modifies
test_utilserver listener on port4550(REDIRECT_ABSOLUTE_PORT) to allow for specifyingredirect_toquery param, that fill use that value for it's next redirect.Note: it uses
tokio::Runtime::block_onasHttpClientmethods are all async, but I didn’t want to translate whole pipeline into async, due to the fact that the case I’m solving here is rather rare one.Fixes #17409