Make displayText in createNetwork optional #7112

rahulbcn27 · 2023-01-19T09:18:01Z

Description

This is a improvement change to make displayText field optional for createNetwork as mentioned in issue #6855.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

rohityadavcloud · 2023-01-19T09:36:37Z

@blueorangutan ui

blueorangutan · 2023-01-19T09:37:03Z

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

rohityadavcloud · 2023-01-19T09:37:08Z

@blueorangutan ui

blueorangutan · 2023-01-19T09:38:03Z

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

DaanHoogland · 2023-01-19T09:38:08Z

ui/src/views/network/CreateIsolatedNetworkForm.vue

            </template>
            <a-input
-             v-model:value="form.displaytext"
+             v-model:value="form.name"


@rahulbcn27 , I don´t mean to take the name unconditionally, but only when the users decides to submit without a value added in the displaytext field.

I would recommend to make the field optional on the command and implement the check on the service.

Thanks @DaanHoogland for the comment. I am implementing the change suggested by you and Rohit.

blueorangutan · 2023-01-19T09:43:22Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7112 (QA-JID-32)

blueorangutan · 2023-01-19T09:44:09Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7112 (QA-JID-33)

codecov · 2023-01-19T10:13:43Z

Codecov Report

Merging #7112 (4034fc1) into main (e8c32d6) will increase coverage by 0.84%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7112      +/-   ##
============================================
+ Coverage     11.78%   12.63%   +0.84%     
- Complexity     7668     8609     +941     
============================================
  Files          2503     2711     +208     
  Lines        245981   255748    +9767     
  Branches      38380    39871    +1491     
============================================
+ Hits          28988    32303    +3315     
- Misses       213222   219347    +6125     
- Partials       3771     4098     +327

Impacted Files	Coverage Δ
...com/cloud/agent/manager/ConnectedAgentAttache.java	`25.00% <0.00%> (-12.50%)`	⬇️
...ubernetes/cluster/utils/KubernetesClusterUtil.java	`2.28% <0.00%> (-8.18%)`	⬇️
.../apache/cloudstack/metrics/MetricsServiceImpl.java	`12.43% <0.00%> (-2.52%)`	⬇️
...apache/cloudstack/syslog/AlertsSyslogAppender.java	`56.49% <0.00%> (-2.26%)`	⬇️
.../main/java/com/cloud/domain/dao/DomainDaoImpl.java	`19.49% <0.00%> (-1.89%)`	⬇️
...ava/com/cloud/upgrade/dao/Upgrade41510to41520.java	`12.50% <0.00%> (-1.79%)`	⬇️
...ava/com/cloud/upgrade/dao/Upgrade41720to41800.java	`0.85% <0.00%> (-1.04%)`	⬇️
...ava/com/cloud/upgrade/dao/Upgrade41520to41600.java	`6.45% <0.00%> (-1.02%)`	⬇️
.../src/main/java/com/cloud/configuration/Config.java	`88.91% <0.00%> (-0.82%)`	⬇️
...udstack/consoleproxy/ConsoleAccessManagerImpl.java	`4.90% <0.00%> (-0.65%)`	⬇️
... and 282 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

blueorangutan · 2023-01-19T11:35:03Z

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2023-01-19T11:40:56Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7112 (QA-JID-34)

DaanHoogland

looks mostly good, I am not sure if my suggestion is needed. If empty string is checked for elsewhere, it isn´t. Please check or change.

api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java

rahulbcn27 · 2023-01-24T05:40:22Z

@blueorangutan ui

blueorangutan · 2023-01-24T05:41:03Z

@rahulbcn27 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2023-01-24T05:47:20Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7112 (QA-JID-36)

rahulbcn27 · 2023-01-24T06:56:44Z

@blueorangutan ui

blueorangutan · 2023-01-24T06:57:02Z

@rahulbcn27 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2023-01-24T07:03:23Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7112 (QA-JID-37)

rohityadavcloud

I don't see UI changes.

You can add unit test
You need to ask somebody to manually QA your feature for UI changes which arent' covered by automated tests

api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java

DaanHoogland

looks good, now we have to decide if we merge like this or apply this concequently throughout as requested in #6855 . I am fine with this, but it not closing that

api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java

…rk/CreateNetworkCmd.java Co-authored-by: Stephan Krug <stekrug@icloud.com>

vladimirpetrov · 2023-01-27T09:08:56Z

Only 'Create network' has been fixed, here are the operations that still require 'displaytext' as a mandatory parameter:

create disk offering
create service (system, compute) offering
create network offering
create vpcoffering
create project
create vpc
create template from volume
register/upload template
register/upload ISO

rohityadavcloud · 2023-01-30T12:35:21Z

@vladimirpetrov the issue is very general in nature; in the #6855 issue, Daan has only mentioned for the create Network form. I think we can start with that and explore all the other forms/actions you've identified.

@rahulbcn27 can you review the outstanding remarks and;

Update the PR subject to reflect what change you're doing
Open a new issue to log requests from Vladi (to address them) or ask @DaanHoogland to update UI/API: make display elements optional #6855 the list
Add unit test or marvin test on your changes

@blueorangutan package

blueorangutan · 2023-01-30T12:36:03Z

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-01-30T13:29:40Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5443

DaanHoogland · 2023-01-30T13:42:33Z

@vladimirpetrov the issue is very general in nature; in the #6855 issue, Daan has only mentioned for the create Network form. I think we can start with that and explore all the other forms/actions you've identified.

@rahulbcn27 can you review the outstanding remarks and;
* Update the PR subject to reflect what change you're doing

* Open a new issue to log requests from Vladi (to address them) or ask @DaanHoogland  to update [UI: make display elements optional #6855](https://github.com/apache/cloudstack/issues/6855) the list

* Add unit test or marvin test on your changes
@blueorangutan package

@rahulbcn27 @rohityadavcloud I'll update the issue, create network was only meant to be an example. I revise the text if needed.

blueorangutan · 2023-01-30T13:43:04Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with

@rahulbcn27 @rohityadavcloud I'll update the issue, create network was only meant to be an example. I revise the text if needed. SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2023-01-30T14:37:02Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5447

stephankruggg

CLGTM

rahulbcn27 · 2023-01-31T03:07:46Z

Thanks @DaanHoogland for updating the PR subject line.

test/integration/smoke/test_create_network.py

api/src/test/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmdTest.java

…into feature_x

Co-authored-by: dahn <daan.hoogland@gmail.com>

sonarqubecloud · 2023-02-08T13:41:19Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

63.6% Coverage
0.0% Duplication

rohityadavcloud · 2023-02-09T11:18:59Z

@DaanHoogland did we run smoketests on this?

DaanHoogland · 2023-02-09T11:30:45Z

oh, good point, we did but I don´t see results. i did run the unit test, but I'll restart teh smoke tests on the healcheck PR

boring-cyborg bot added the component:UI label Jan 19, 2023

DaanHoogland reviewed Jan 19, 2023

View reviewed changes

First Version of UI fix

90afe09

boring-cyborg bot added component:api component:networking labels Jan 23, 2023

rahulbcn27 requested a review from DaanHoogland January 23, 2023 05:42

DaanHoogland reviewed Jan 23, 2023

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java Outdated Show resolved Hide resolved

First Version of Fix

fc90a1f

Added displayText Fix

3f5aa01

rohityadavcloud requested changes Jan 24, 2023

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java Show resolved Hide resolved

api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java Outdated Show resolved Hide resolved

New fix of displayText added

02ec284

rahulbcn27 requested review from DaanHoogland and rohityadavcloud and removed request for DaanHoogland January 25, 2023 05:03

DaanHoogland approved these changes Jan 25, 2023

View reviewed changes

stephankruggg reviewed Jan 26, 2023

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java Outdated Show resolved Hide resolved

Update api/src/main/java/org/apache/cloudstack/api/command/user/netwo…

3b7486d

…rk/CreateNetworkCmd.java Co-authored-by: Stephan Krug <stekrug@icloud.com>

rahulbcn27 requested a review from stephankruggg January 30, 2023 09:34

DaanHoogland changed the title ~~Make display elements optional~~ Make displayText in createNetwork optional Jan 30, 2023

stephankruggg approved these changes Jan 30, 2023

View reviewed changes

boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Feb 3, 2023

DaanHoogland reviewed Feb 3, 2023

View reviewed changes

test/integration/smoke/test_create_network.py Show resolved Hide resolved

test/integration/smoke/test_create_network.py Outdated Show resolved Hide resolved

DaanHoogland reviewed Feb 3, 2023

View reviewed changes

api/src/test/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmdTest.java Show resolved Hide resolved

Rahul Agarwal and others added 7 commits February 3, 2023 16:31

Unit and Marvin Test added

e8b2e79

Merge branch 'feature_x' of https://github.com/rahulbcn27/cloudstack …

583160f

…into feature_x

simulator added in tags of create network test

b35d932

Netname added in Test method

8abb798

Suggested change added to Unit and Marvin Test

3783f56

Extra lines removed EOF in create_network_py

01be6c5

Update test/integration/smoke/test_create_network.py

4034fc1

Co-authored-by: dahn <daan.hoogland@gmail.com>

DaanHoogland added this to the 4.18.0.0 milestone Feb 8, 2023

DaanHoogland merged commit 0efa4f6 into apache:main Feb 8, 2023

weizhouapache mentioned this pull request Jun 22, 2023

UI/API: make display elements optional #6855

Closed

10 tasks

Make displayText in createNetwork optional #7112

Make displayText in createNetwork optional #7112

Uh oh!

Conversation

rahulbcn27 commented Jan 19, 2023 • edited by DaanHoogland Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

rohityadavcloud commented Jan 19, 2023

Uh oh!

blueorangutan commented Jan 19, 2023

Uh oh!

rohityadavcloud commented Jan 19, 2023

Uh oh!

blueorangutan commented Jan 19, 2023

Uh oh!

DaanHoogland Jan 19, 2023

Choose a reason for hiding this comment

Uh oh!

rahulbcn27 Jan 21, 2023

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jan 19, 2023

Uh oh!

blueorangutan commented Jan 19, 2023

Uh oh!

codecov bot commented Jan 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jan 19, 2023

Uh oh!

blueorangutan commented Jan 19, 2023

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rahulbcn27 commented Jan 24, 2023

Uh oh!

blueorangutan commented Jan 24, 2023

Uh oh!

blueorangutan commented Jan 24, 2023

Uh oh!

rahulbcn27 commented Jan 24, 2023

Uh oh!

blueorangutan commented Jan 24, 2023

Uh oh!

blueorangutan commented Jan 24, 2023

Uh oh!

rohityadavcloud left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vladimirpetrov commented Jan 27, 2023

Uh oh!

rohityadavcloud commented Jan 30, 2023

Uh oh!

blueorangutan commented Jan 30, 2023

Uh oh!

blueorangutan commented Jan 30, 2023

Uh oh!

DaanHoogland commented Jan 30, 2023

Uh oh!

blueorangutan commented Jan 30, 2023

Uh oh!

blueorangutan commented Jan 30, 2023

Uh oh!

stephankruggg left a comment

rahulbcn27 commented Jan 19, 2023 •

edited by DaanHoogland

Loading

codecov bot commented Jan 19, 2023 •

edited

Loading