shellIntegrationAddon.ts: only decode messages for VSCodeOScPt, not iTerm2 #165579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwe
force-pushed
the
shellint-no-decode-iterm2
branch
from
5b03427
to
3e49113
Compare
rwe
force-pushed
the
shellint-no-decode-iterm2
branch
from
3e49113
to
709af80
Compare
rwe
force-pushed
the
shellint-no-decode-iterm2
branch
from
709af80
to
78b1361
Compare
Tyriar
approved these changes
Nov 23, 2022
connor4312
approved these changes
Nov 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Unlike
VSCodeOscPt.Property, the iTerm2 OSC sequences do not support backslash or hex-escape sequences. Interpretation of those messages should not attempt evaluation of those escapes.See: https://github.com/gnachman/iTerm2/blob/bb0882332cec5196e4de4a4225978d746e935279/sources/VT100Terminal.m#L2089-L2105