DanielRosenwasser
Follow
Pinned
748 contributions in the last year
We're celebrating 100 million developers!
Contribution activity
January 2023
Created 9 commits in 3 repositories
Created a pull request in microsoft/TypeScript that received 44 comments
Use a const type parameter for Object.freeze.
This PR removes an unnecessary signature from Object.freeze by using TypeScript 5.0's new const type parameters.
I think if we want to try this out…
+174
−161
•
44
comments
Opened 2 other pull requests in 1 repository
microsoft/TypeScript
1
open
1
closed
Reviewed 43 pull requests in 1 repository
microsoft/TypeScript
25 pull requests
- Remove extra checkDefined in visitEachChildOfJsxExpression
- Fix typo in diagnostic messages
- Mark new createPrinter vars as pure to remove new code from typingsInstaller
-
Fix auto-imports with
--moduleResolution bundlerandcustomConditions - Reuse Printers with common options
- Add 2023 array methods to target features
- Revert part of catch clause PR which broke other declarations
- fix(52386): JSDoc code fixes for arrow-function initialized const duplicates comment
- feat(52366): @prop is not provided as a valid JSDoc tag in autocompletion
- Add linkcode and linkplain to jsdoc tags
- Remove line/col for all lib file diagnostics in baselines, completions
- fix completion text of exported types
- Fix(51162): TS Server fatal error
- Swap minestarks for zkat and joj in fabricbot.json
- fix(396): (Dis)allow Octal and Bad Escape Sequences in String and (Tagged) Template Literals
- Remove long deprecated completions protocol commands
- Change default newLine, forceConsistentCasingInFileNames
- Update DOM and baselines
-
Check if
hasOwnPropertybefore accessingtoStringproperty of object - fix(51521): Using a of property declared after an initializing constructor triggers an assertion failure in JS
- Change default newline + turn on forceConsistentCasingInFileNames
- Fix issue with ambient property declaration following property assignment in JS
- Derive allCommandNames from CommandTypes enum
-
Use a
consttype parameter forObject.freeze. - Implement the Stage 3 Decorators Proposal
- Some pull request reviews not shown.
Created an issue in microsoft/TypeScript that received 12 comments
Design Meeting Notes, 1/18/2023
newLine and forceConsistentFileNames Defaults
#51909
newLine to lf?
Didn't get to discuss it thoroughly.
Change default of forceConsistentFileN…
12
comments
Opened 28 other issues in 4 repositories
microsoft/TypeScript
15
open
9
closed
- Design Meeting Notes, 1/27/2023
- Design Meeting Notes, 1/25/2023
-
Tighter parameter decorator checking with
--experimentalDecorators -
JSDoc code fixes for arrow-function initialized
constduplicates comment -
Provide snippet completions for
@paramin JSDoc - Errors not reported when signature help is active
-
Cannot specify a JSDoc
@overloadsignature using the@typetag -
@overloaddoesn't check implementation against overload signatures -
@propis not provided as a valid JSDoc tag in autocompletion - JSDoc comment templates/scaffolding may not use formatter newlines
- Design Meeting Notes, 1/20/2023
-
switch/casecompletions fail when has a negative literal type - Extensionful completions are not provided once it becomes clear-ish that an extension is being typed
-
Use context to prioritize or only show
caseanddefaultin aswitchstatement - Ambient modules declared with patterns are offered in path completions
- Design Meeting Notes, 1/13/2023
-
Provide
lib/targetsuggestions forfindLast/findLastIndex - No member completions, and irrelevant value completions, when class property initializer has no semicolon
- No completions for methods following property declaration
- Design Meeting Notes, 1/11/2023
- Design Meeting Notes, 1/6/2023
-
Shorthand properties with
=cause assertion failures inconsumeTokenAndAdvanceScanner - Design Meeting Notes, 1/4/2023
- Class member snippets should probably not have a lower priority than keywords