GH-100762: Don't call gen.throw() in gen.close(), unless necessary.
#101013
+36
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpensive gen.throw() in gen.close() where possible.
|
Using the benchmarks in #101011 (comment), but using |
brandtbucher
approved these changes
Jan 18, 2023
|
|
||
| # Python 3.12a1 3517 (Change YIELD_VALUE oparg to exception block depth) |
There was a problem hiding this comment.
I'm guessing you have a 3516 PR open somewhere?
gvanrossum
reviewed
Jan 18, 2023
| .. versionchanged:: 3.11 | ||
| oparg set to be the stack depth, for efficient handling on frames. | ||
| .. versionchanged:: 3.12 | ||
| oparg set to be the exception block depth, for efficient closing of generators. |
There was a problem hiding this comment.
Shouldn't the 3.11 note be retained (assuming it's truthful)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Change
opargofYIELD_VALUEto hold the exception handler depth.We can then test that in
gen.close()to avoid callinggen.throw()unless necessary.