Skip to content

close tainted connection after evicting from pool#354

Merged
pmlopes merged 1 commit into
vert-x3:masterfrom
Eng-Fouad:patch-1
Oct 24, 2022
Merged

close tainted connection after evicting from pool#354
pmlopes merged 1 commit into
vert-x3:masterfrom
Eng-Fouad:patch-1

Conversation

@Eng-Fouad
Copy link
Copy Markdown
Contributor

Fixes #353

@cescoffier cescoffier requested a review from pmlopes October 19, 2022 12:10
@pmlopes
Copy link
Copy Markdown
Member

pmlopes commented Oct 19, 2022

Yes, we can be more strict and remove the bad connections from the pool immediately instead of keep them stalling the pool and degrading it, until a timeout occurs.

@pmlopes pmlopes merged commit 1df5131 into vert-x3:master Oct 24, 2022
@pmlopes pmlopes added the bug label Oct 24, 2022
@pmlopes pmlopes added this to the 4.3.5 milestone Oct 24, 2022
@Eng-Fouad Eng-Fouad deleted the patch-1 branch December 5, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

PooledRedisConnection.close() does not close the connection if it is tainted (Pub/Sub)

2 participants