Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
colon in Path generate "resource not Found" #871
Comments
|
The character : should be encoded https://perishablepress.com/stop-using-unsafe-characters-in-urls/ |
|
forget to mention, of course it was encoded, just pasted here decoded |
|
i will look at it |
|
some hint, when using regular vertx router , then all is fine
only when switching to OpenAPI3RouterFactory, problem appears Additional info. yml defintion says about this parameter as
|
|
Please check this PR: #872 |
|
thank you. Looks promising. |
|
I can see it will be released with 3.6.0 , right? |
|
is there chance for inter release like 3.5.2 ? |
|
after fix, I will be able to use |
|
I don't know when the next version will be release. I think that : won't work because it's a reserved character that should be escaped |
|
In the spec (https://tools.ietf.org/html/rfc3986#section-3.3) we found out that ':' is technically valid in the path segment of a url - so we do not need encode |
|
Please look at field allowReserved (that we don't support, we assert that is always false) https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.1.md#fixed-fields-10 |
|
I've created a new PR that refactor the path generation: #884 |
Version
Context
We have to expose API with path, which includes
:(colon) like : domain/v1/user/aa:bb/subscriptionsIt looks our router is not able to match to any of our endpoint
Fragment from openapi.yaml (yes, we are using OpenAPI3RouterFactory)
PS
Present response : "Resource not found"