Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OAuth2Auth extend directly AuthProvider #246

Closed
vietj opened this issue Oct 6, 2018 · 0 comments
Closed

Make OAuth2Auth extend directly AuthProvider #246

vietj opened this issue Oct 6, 2018 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@vietj
Copy link
Contributor

@vietj vietj commented Oct 6, 2018

Currently OAuth2Auth inherits AuthProvider via the intermediate AuthProviderInternal interface. OAuth2Auth should directly extend it and AuthProviderInternal should be rather only implemented by OAuth2AuthProviderImpl. Code relying on this should use the instanceof operator to check when the provider is actually internal and make a cast (which is likely the case already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.