Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing @Nullable annotations #2434

Closed
tsegismont opened this issue May 8, 2018 · 2 comments
Closed

Missing @Nullable annotations #2434

tsegismont opened this issue May 8, 2018 · 2 comments
Milestone

Comments

@tsegismont
Copy link
Contributor

@tsegismont tsegismont commented May 8, 2018

Building this list so that we can track any missing @Nullable annotation until 3.6 is released

[ ] Vertx.executeBlocking

[ ] Context.executeBlocking

[ ] WorkerExecutor.executeBlocking

[ ] AsyncMap.get
[ ] AsyncMap.putIfAbsent
[ ] AsyncMap.remove
[ ] AsyncMap.replace

------ Original comment

Currently, the executeBlocking result handler type is not annotated with @Nullable.

As a result, the generated Rxified API returns a Single<T>. But it's quite common to use Future<Void> for a blocking task which does not need to return any result.
Then if the user simply invoke future.complete(), the program fails at runtime.

As a workaround, the user can use a Future<Object> and invoke complete() with any non-null value.

@tsegismont
Copy link
Contributor Author

@tsegismont tsegismont commented May 8, 2018

@vietj there's a similar issue with AsyncMap.get, AsyncMap.putIfAbsent and AsyncMap.remove. Should I create another issue or rename this one?

@vietj
Copy link
Member

@vietj vietj commented May 9, 2018

I think a single issue to fix all missing @Nullable is good

@tsegismont tsegismont added this to the 3.6.0 milestone May 15, 2018
@tsegismont tsegismont changed the title executeBlocking result handler type not annotated with @Nullable Missing @Nullable annotations May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.