Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple the FileResolver from a Vertx instance #2428

Closed
vietj opened this issue May 5, 2018 · 0 comments
Closed

Decouple the FileResolver from a Vertx instance #2428

vietj opened this issue May 5, 2018 · 0 comments
Milestone

Comments

@vietj
Copy link
Member

@vietj vietj commented May 5, 2018

Motiviation: currently the FileResolver is in the io.vertx.core.impl package and owns a Vertx instance. The only reason it needs this instance is to delete the cache dir when it is closed, because it actually needs to schedule a blocking file deletion (via the filesystem instance).

Change: decouple the FileResolver from the Vertx instance and the FileSystem implementation so it can be used without Vertx or FileResolver. The close operation is now blocking and the callers run it in an execute internal blocking operation (Vert.x close) or a thread (at JVM shutdown).

vietj added a commit that referenced this issue May 5, 2018
@vietj vietj added this to the 3.6.0 milestone May 5, 2018
@vietj vietj closed this in fb9272c May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.