Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up
Motiviation: currently the
FileResolveris in theio.vertx.core.implpackage and owns aVertxinstance. The only reason it needs this instance is to delete the cache dir when it is closed, because it actually needs to schedule a blocking file deletion (via the filesystem instance).Change: decouple the
FileResolverfrom theVertxinstance and theFileSystemimplementation so it can be used withoutVertxorFileResolver. The close operation is now blocking and the callers run it in an execute internal blocking operation (Vert.x close) or a thread (at JVM shutdown).