Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context improvements #2359

Closed
vietj opened this issue Mar 29, 2018 · 0 comments
Closed

Context improvements #2359

vietj opened this issue Mar 29, 2018 · 0 comments
Assignees
Labels
Milestone

Comments

@vietj
Copy link
Member

@vietj vietj commented Mar 29, 2018

A few improvements and simplifications can be done in Vert.x Context

  • remove the internal ContextTask functional interface (which is a Runnable that can throw) as we can use Handler<Void> in practice which unified the internal Context#wrapTask method
  • remove the internal Action functional interface (which is similar to a Callable) as we can use the Handler<Future<T>> idiom instead
  • add a ContextInternal#executeFromIO(T,Handler<T>) so an handler task can be passed an argument
  • decompose the implementation of ContextImpl#wrapTask so the logic can be reused by executeFromIO without creating a unnecessary lambda
  • handle the worker task metric in WorkerContext instead of ContextImpl#wrapTask
  • avoid unnecessary lambda captures in VertxHandler when handling a message from Netty
@vietj vietj added this to the 3.6.0 milestone Mar 29, 2018
@vietj vietj self-assigned this Mar 29, 2018
@vietj vietj added the enhancement label Apr 4, 2018
@vietj vietj closed this in #2360 Apr 5, 2018
@vietj vietj removed the to review label Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.