Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-100815: Normalize types module usage in copy module #100816

Merged
merged 1 commit into from Jan 7, 2023

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 7, 2023

Copy link
Member

@terryjreedy terryjreedy left a comment

I consider the false implication of the getattr and test to be a buglet.

The changes for None, etc, are not necessary, but given that the types module is already imported, I think using it consistently as the source of truth is a good idea.

In the deepcopy list, I think that the CodeType line should have been just above the function lines, but I am refraining from suggesting that it be moved now.

@AlexWaygood AlexWaygood merged commit 951303f into python:main Jan 7, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants