Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Action Modifications #46066

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Github Action Modifications #46066

wants to merge 13 commits into from
+9 −4

Conversation

AquaBx
Copy link

@AquaBx AquaBx commented Jan 2, 2023

Hi, I modified the Github Actions for Windows to include arm64, x86 and windows-latest in the tests

.github/workflows/coverage-windows.yml

strategy:
      matrix:
        windows: [windows-2019,windows-latest]
        arch: [x86,x64,arm64]
    runs-on: ${{matrix.windows}}

...

run: ./vcbuild.bat ${{matrix.arch}} test-ci-js; node -e 'process.exit(0)'

.github/workflows/build-windows.yml

    strategy:
      matrix:
        windows: [windows-2019,windows-latest]
        arch: [x86,x64,arm64]
      fail-fast: false
    runs-on: ${{ matrix.windows }}

...

run: ./vcbuild.bat ${{matrix.arch}}

@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Jan 2, 2023

Review requested:

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AquaBx @nodejs-github-bot