Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release_plan.md #20351

Merged
merged 10 commits into from Dec 16, 2022
Merged

Update release_plan.md #20351

merged 10 commits into from Dec 16, 2022

Conversation

eleanorjboyd
Copy link
Member

@eleanorjboyd eleanorjboyd commented Dec 9, 2022

Hello! I went through and made edits to try and help clarify the release process and all the different branches and PRs that we are creating/keeping track of. I wrote it in a way that makes the most sense to me but please let me know where it is confusing for you.

@paulacamargo25 could you review this first, make edits, and then add @brettcannon as a reviewer?

Thanks!

@eleanorjboyd eleanorjboyd requested a review from paulacamargo25 Dec 9, 2022
@eleanorjboyd eleanorjboyd self-assigned this Dec 9, 2022
Copy link
Member Author

@eleanorjboyd eleanorjboyd left a comment

a few notes and asks

.github/release_plan.md Outdated Show resolved Hide resolved
##### Bump the version of `main` to be a release candidate (also updating debugpy dependences, third party notices, and package-lock.json).❄️

- [ ] `git fetch` to ensure you are up to date with `main` on your local machine.
- [ ] Create a new branch called **`bump-release-[YYYY.minor]`**.
Copy link
Member Author

@eleanorjboyd eleanorjboyd Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in a naming scheme for all branches one creates to hopefully clarify their functionality and lifespan. Open to suggestions on the naming conventions so plz let me know if you think of something better.

- [ ] Begin drafting a [blog](http://aka.ms/pythonblog) post. Contact the PM team for this.
NOTE: Third Party Notices are automatically added by our build pipelines using https://tools.opensource.microsoft.com/notice.

### Step 1:
Copy link
Member Author

@eleanorjboyd eleanorjboyd Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broke the doc down into these "steps" which I thought provided more separation between the different actions taken then the previous format but let me know if this makes it more confusing.

.github/release_plan.md Outdated Show resolved Hide resolved

NOTE: this PR should be passing CI and will return `main` to passing CI from step 1.

### Step 5: Notifications and Checks on External Release Factors
Copy link
Member Author

@eleanorjboyd eleanorjboyd Dec 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had trouble naming this step- very open to suggestions

.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
@eleanorjboyd eleanorjboyd added the no-changelog No news entry required label Dec 9, 2022
paulacamargo25
paulacamargo25 previously approved these changes Dec 13, 2022
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
Co-authored-by: Brett Cannon <brcan@microsoft.com>
@eleanorjboyd eleanorjboyd requested a review from brettcannon Dec 14, 2022
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
Copy link

@karrtikr karrtikr left a comment

Thanks for taking this on!

.github/release_plan.md Outdated Show resolved Hide resolved
eleanorjboyd and others added 2 commits Dec 15, 2022
Co-authored-by: Kartik Raj <karraj@microsoft.com>
brettcannon
brettcannon previously approved these changes Dec 15, 2022
.github/release_plan.md Outdated Show resolved Hide resolved
Co-authored-by: Brett Cannon <brcan@microsoft.com>
.github/release_plan.md Outdated Show resolved Hide resolved
.github/release_plan.md Outdated Show resolved Hide resolved
karrtikr
karrtikr previously approved these changes Dec 16, 2022
Copy link

@karrtikr karrtikr left a comment

Changes would be nice but not required.

Co-authored-by: Kartik Raj <karraj@microsoft.com>
@eleanorjboyd eleanorjboyd merged commit 5e83629 into main Dec 16, 2022
44 checks passed
@eleanorjboyd eleanorjboyd deleted the edits-to-release-steps branch Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants