bpo-46483: remove __class_getitem__ from pathlib.PurePath
#30848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
Jan 24, 2022
| @@ -0,0 +1 @@ | |||
| Remove ``__class_getitem__`` from :class:`pathlib.PurePath` | |||
There was a problem hiding this comment.
It might be good to:
- Give a one-sentence description of why it's being removed.
- Delete the news entry that was added in bpo-46483: change
PurePath.__class_getitem__to returnGenericAlias#30822 (it'll make for a pretty confusing changelog otherwise).
serhiy-storchaka
reviewed
Jan 24, 2022
| @@ -0,0 +1 @@ | |||
| Remove ``__class_getitem__`` from :class:`pathlib.PurePath` | |||
There was a problem hiding this comment.
Suggested change
| Remove ``__class_getitem__`` from :class:`pathlib.PurePath` | |
| Remove ``__class_getitem__`` from :class:`pathlib.PurePath`. |
kumaraditya303
reviewed
Jan 24, 2022
Misc/NEWS.d/next/Library/2022-01-24-13-00-09.bpo-46483.9XnmKp.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
|
Please add also a What's New entry (in the Removed section). I think in this case we can cut the deprecation period, as this feature was added by mistake and was unlikely used in user code. But it is still a breaking change which should be documented. |
serhiy-storchaka
approved these changes
Feb 3, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
@serhiy-storchaka proposed removing
__class_getitem__fromPurePath.CC @asvetlov and @isidentical as original PR authors: #17498
Why?
PurePathalways works withstr(unlikeos.PathLike[bytes | str]PurePathis not generic: https://github.com/python/typeshed/blob/35064a7f759facd7c3787ab6095964008f97d873/stdlib/pathlib.pyi#L20Related #30822
CC @corona10 as my mentor
https://bugs.python.org/issue46483