Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-98831: Typed stack effects, and more instructions converted #99764

Merged
merged 34 commits into from Dec 8, 2022
Merged

GH-98831: Typed stack effects, and more instructions converted #99764

merged 34 commits into from Dec 8, 2022
+545 −604

Commits on Dec 3, 2022

  1. Make BINARY_OP_INPLACE_ADD_UNICODE a legit super instruction 

    This doesn't really make things much cleaner, but it works.
    @gvanrossum
    gvanrossum committed Dec 3, 2022
    6860ed7

  2. COMPARE_OP

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    dcba32e

  3. COMPARE_OP_FLOAT_JUMP

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    30cb8cd

  4. COMPARE_OP_INT_JUMP

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    6af0a5d

  5. COMPARE_OP_STR_JUMP

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    039efbf

  6. Support typed stack effects 

    This was more convoluted than I expected.
    @gvanrossum
    gvanrossum committed Dec 3, 2022
    2fd8822

  7. Refactor common code of analyze_{super,macro} 

    Also removed some dead code from the former
(somehow the case for CacheEffect had crept back in).
    @gvanrossum
    gvanrossum committed Dec 3, 2022
    14bbd50

  8. Reverse temporary variable numbering 

    This makes the PEEK/POKE sequences less jarring.
    @gvanrossum
    gvanrossum committed Dec 3, 2022
    00a2495

  9. STORE_ATTR

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    f01dff5

  10. DELETE_ATTR

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    71ee089

  11. STORE_GLOBAL

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    966da1a

  12. STORE_ATTR_INSTANCE_VALUE

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    7c94591

  13. STORE_ATTR_WITH_HINT

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    2c76046

  14. STORE_ATTR_SLOT, and complete the store_attr family

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    d0f29f8

  15. Complete the store_subscr family: STORE_SUBSCR{,DICT,LIST_INT} 

    STORE_SUBSCR was alread half converted,
but wasn't using cache effects yet.
    @gvanrossum
    gvanrossum committed Dec 3, 2022
    001c418

  16. DELETE_SUBSCR

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    05caa7e

  17. PRINT_EXPR

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    8d445ae

  18. INTERPRETER_EXIT (a bit weird, ends in return)

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    c1f3034

  19. RETURN_VALUE

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    e2f376b

  20. GET_AITER (had to restructure it some) 

    The original had mysterious `SET_TOP(NULL)` before `goto error`.
I assume those just account for `obj` having been decref'ed,
so I got rid of them in favor of the cleanup implied by `ERROR_IF()`.
    @gvanrossum
    gvanrossum committed Dec 3, 2022
    53c204e

  21. Typo in TODO comment

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    e0ba8bf

  22. Emit PREDICT() macros right before DISPATCH() 

    This should fix the build crash on Windows.
    @gvanrossum
    gvanrossum committed Dec 3, 2022
    f7a54d7

  23. LIST_APPEND (a bit unhappy with it)

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    6ae9e6e

  24. SET_ADD (also a bit unhappy with it)

    @gvanrossum
    gvanrossum committed Dec 3, 2022
    34aa393

Commits on Dec 8, 2022

  1. Move all cache effects to the front of the effects list

    @gvanrossum
    gvanrossum committed Dec 8, 2022
    e144db3

  2. Rename _JUMP_ON_SIGN to _JUMP_IF

    @gvanrossum
    gvanrossum committed Dec 8, 2022
    029bf07

  3. Change ERROR_IF(err != 0, ...) to ERROR_IF(err, ...)

    @gvanrossum
    gvanrossum committed Dec 8, 2022
    fa3135f

  4. Change ERROR_IF(1, ...) to ERROR_IF(true, ...)

    @gvanrossum
    gvanrossum committed Dec 8, 2022
    445f20b

  5. Revert "Make BINARY_OP_INPLACE_ADD_UNICODE a legit super instruction" 

    It was too fancy, and I have another idea for super instructions
and effects anyways.

This reverts commit 6860ed7.
    @gvanrossum
    gvanrossum committed Dec 8, 2022
    32b4ac0

  6. Emit PEEKs in super/macro instructions in correct order

    @gvanrossum
    gvanrossum committed Dec 8, 2022
    0ef4da7

  7. Use JUMPBY(n) instead of next_instr += n

    @gvanrossum
    gvanrossum committed Dec 8, 2022
    7d19466

  8. Rename local variables type to typ

    @gvanrossum
    gvanrossum committed Dec 8, 2022
    99e8ec6

  9. Remove unused op names

    @gvanrossum
    gvanrossum committed Dec 8, 2022
    c08dbdb

  10. Merge branch 'main' into typed-stack-effects

    @gvanrossum
    gvanrossum committed Dec 8, 2022
    c6dfeec