Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29304: Simplify dict lookup functions #2407

Merged
merged 4 commits into from Aug 3, 2017
Merged

bpo-29304: Simplify dict lookup functions #2407

merged 4 commits into from Aug 3, 2017

Conversation

methane
Copy link
Member

@methane methane commented Jun 26, 2017 •
edited by bedevere-bot

@methane
Copy link
Member Author

methane commented Jun 26, 2017

All reason to have duplicated code (introduced by 9930417) are gone in those two functions.
Code before loop and inner loop is most exactly same.

@methane methane changed the title bpo-29304: Simplify lookdict_split and lookdict_unicode_nodummy bpo-29304: Simplify dict lookup functions Jun 27, 2017
pitrou
pitrou reviewed Jun 29, 2017
View changes
Objects/dictobject.c
}
Py_ssize_t hashpos = find_empty_slot(mp->ma_keys, hash);
Copy link
Member

@pitrou pitrou Jun 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we allow declarations in the middle of C blocks now?

Copy link
Member Author

@methane methane Jun 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, from Python 3.6.
While this make hard to backporting future commits to Python 3.5,
Python 3.5 will go security-fix mode soon.

@methane methane merged commit 778928b into python:master Aug 3, 2017
@methane methane deleted the dict-refactor3 branch Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pitrou pitrou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@methane @pitrou @the-knights-who-say-ni