➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2018-10-31 21:47 by scorphus, last changed 2018-11-01 16:27 by scorphus. This issue is now closed.
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 10268 | merged | scorphus, 2018-10-31 23:54 | |
| PR 10280 | merged | serhiy.storchaka, 2018-11-01 11:36 | |
| PR 10281 | merged | serhiy.storchaka, 2018-11-01 11:37 | |
| Messages (9) | |||
|---|---|---|---|
| msg329016 - (view) | Author: Pablo Santiago Blum de Aguiar (scorphus) * | Date: 2018-10-31 21:47 | |
Some warn messages miss space between words, such as: Use of 'buffering' argument is deprecated and ignoredsince Python 3.0. in bz2 library, and: keyfile and certfile are deprecated, use acustom context instead in many libraries, such as poplib and smtplib. Other warn messages contain too much spaces between words, such as: The 'filename' attribute will be removed in future versions. Use 'source' instead. in configparser library. I'm not sure if such issues affect older versions of Python. I might need help on that. |
|||
| msg329017 - (view) | Author: Pablo Santiago Blum de Aguiar (scorphus) * | Date: 2018-10-31 21:55 | |
Sorry, only when creating the PR I read that trivial changes like this need no issue. |
|||
| msg329044 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) *  |
Date: 2018-11-01 05:19 | |
I think double space after a period is not a bug. |
|||
| msg329049 - (view) | Author: Pablo Santiago Blum de Aguiar (scorphus) * | Date: 2018-11-01 09:17 | |
You have a point. They make the message more readable. I've readded the double spaces. |
|||
| msg329051 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-11-01 10:33 | |
New changeset 4b5e62dbb22a3593e0db266c12f805b727a42b00 by Serhiy Storchaka (Pablo Aguiar) in branch 'master': bpo-35128: Fix spacing issues in warning.warn() messages. (GH-10268) https://github.com/python/cpython/commit/4b5e62dbb22a3593e0db266c12f805b727a42b00 |
|||
| msg329055 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-11-01 12:19 | |
New changeset 5e0537cf7e5b0a5ef134c7da0b68b8e55c69f4b0 by Serhiy Storchaka in branch '3.7': [3.7] bpo-35128: Fix spacing issues in warning.warn() messages. (GH-10268). (GH-10280) https://github.com/python/cpython/commit/5e0537cf7e5b0a5ef134c7da0b68b8e55c69f4b0 |
|||
| msg329056 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-11-01 12:19 | |
New changeset 89138f286938753f273c90547491efe374e617c1 by Serhiy Storchaka in branch '3.6': [3.6] bpo-35128: Fix spacing issues in warning.warn() messages. (GH-10268). (GH-10281) https://github.com/python/cpython/commit/89138f286938753f273c90547491efe374e617c1 |
|||
| msg329057 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * |
Date: 2018-11-01 12:24 | |
Seems 2.7 is not affected. |
|||
| msg329077 - (view) | Author: Pablo Santiago Blum de Aguiar (scorphus) * | Date: 2018-11-01 16:27 | |
Thanks again for reviewing, merging and backporting. Next time I'll try and backport as well :-) |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2018-11-01 16:27:34 | scorphus | set | messages: + msg329077 |
| 2018-11-01 12:24:14 | serhiy.storchaka | set | status: open -> closed resolution: fixed messages: + msg329057 stage: patch review -> resolved |
| 2018-11-01 12:19:40 | serhiy.storchaka | set | messages: + msg329056 |
| 2018-11-01 12:19:27 | serhiy.storchaka | set | messages: + msg329055 |
| 2018-11-01 11:37:52 | serhiy.storchaka | set | pull_requests: + pull_request9592 |
| 2018-11-01 11:36:22 | serhiy.storchaka | set | keywords:
+ patch pull_requests: + pull_request9591 |
| 2018-11-01 10:33:47 | serhiy.storchaka | set | messages: + msg329051 |
| 2018-11-01 09:17:21 | scorphus | set | messages: + msg329049 |
| 2018-11-01 05:20:49 | serhiy.storchaka | set | type: behavior components: + Library (Lib) |
| 2018-11-01 05:20:08 | serhiy.storchaka | set | status: closed -> open stage: resolved -> patch review |
| 2018-11-01 05:19:14 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg329044 |
| 2018-10-31 23:54:52 | scorphus | set | pull_requests: + pull_request9581 |
| 2018-10-31 21:55:38 | scorphus | set | status: open -> closed messages: + msg329017 stage: resolved |
| 2018-10-31 21:47:42 | scorphus | create | |