Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40939: Generate keyword.py using pegen #20800

Merged
merged 3 commits into from Jun 11, 2020
Merged

bpo-40939: Generate keyword.py using pegen #20800

merged 3 commits into from Jun 11, 2020

Conversation

lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented Jun 11, 2020 •
edited by bedevere-bot

@lysnikolaou lysnikolaou requested a review from pablogsal as a code owner Jun 11, 2020
pablogsal
pablogsal requested changes Jun 11, 2020
View changes
Lib/keyword.py Show resolved Hide resolved
@bedevere-bot
Copy link

bedevere-bot commented Jun 11, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@pablogsal
Copy link
Member

pablogsal commented Jun 11, 2020

Can you also update the Windows regen file? (PCbuild/regen.vcxproj)

@pablogsal pablogsal mentioned this pull request Jun 11, 2020
Merged
@lysnikolaou lysnikolaou requested a review from a team as a code owner Jun 11, 2020
@lysnikolaou lysnikolaou requested a review from pablogsal Jun 11, 2020
@pablogsal pablogsal merged commit 9727694 into python:master Jun 11, 2020
4 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jun 11, 2020

Thanks @lysnikolaou for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@pablogsal
Copy link
Member

pablogsal commented Jun 11, 2020

Thanks for the PR, @lysnikolaou! 🚀

@bedevere-bot
Copy link

bedevere-bot commented Jun 11, 2020

GH-20801 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jun 11, 2020
@miss-islington @lysnikolaou
bpo-40939: Generate keyword.py using the new parser (GH-20800)
961edf7 
(cherry picked from commit 9727694)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@lysnikolaou lysnikolaou deleted the keywordgen branch Jun 11, 2020
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@lysnikolaou @arun-mani-j
bpo-40939: Generate keyword.py using the new parser (pythonGH-20800)
f427a2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@python/windows-team windows-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lysnikolaou @bedevere-bot @pablogsal @miss-islington @the-knights-who-say-ni