Skip to content

gh-99724 - wave.py - Support for ALAW and ULAW formats#99725

Closed
thiborose wants to merge 2 commits into
python:mainfrom
thiborose:main
Closed

gh-99724 - wave.py - Support for ALAW and ULAW formats#99725
thiborose wants to merge 2 commits into
python:mainfrom
thiborose:main

Conversation

@thiborose
Copy link
Copy Markdown

@thiborose thiborose commented Nov 23, 2022 •
edited by bedevere-bot
Loading 

>>> import wave
>>> wf1 = wave.open("ulaw08s.wav", "r") # no reading error!
>>> wf2 = wave.open("output.wav", "wb")
>>> 
>>> wf2.setparams(wf1.getparams())
>>> wf2.writeframes(wf1.readframes(-1)) # no writing error!
>>>
>>> wf1.close()
>>> wf2.close()

fix #99724

@thiborose
Support for ALAW and ULAW formats
7ccae2d 
Signed-off-by: psawa <38402230+psawa@users.noreply.github.com>
@ghost
Copy link
Copy Markdown

ghost commented Nov 23, 2022 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot mentioned this pull request Nov 23, 2022
Closed
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Nov 23, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@encukou
Copy link
Copy Markdown
Member

encukou commented Mar 25, 2024

Thank you for the change, but I cannot accept it as is. It would need rationale, discussion, and tests. See the issue for more.

@encukou encukou closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wave.py - support for ulaw and alaw formats

3 participants

@thiborose @bedevere-bot @encukou