gh-87888: Make FileCookieJar use ASCII/surrogateescape#92392
Closed
methane wants to merge 5 commits into
Closed
Conversation
…ding * Byte transparent reading and writing. * Consistent with WSGI. * Avoid UnicodeDecodeError when reading comments.
methane
changed the title
iritkatriel
requested changes
Nov 27, 2022
iritkatriel
left a comment
iritkatriel
left a comment
Member
There was a problem hiding this comment.
There is a merge conflict now. Is this still needed?
|
When you're done making the requested changes, leave the comment: And if you don't make the requested changes, you will be poked with soft cushions! |
methane
changed the title
Member
Author
|
I changed to use ASCII/surrogateescape instead of latin-1. |
|
This PR is stale because it has been open for 30 days with no activity. |
Member
Author
|
I think it would be correct to use ASCII by default. However, for backward compatibility, it might be a better choice to leave the code as is and let PEP 686 use UTF-8 by default. Users who need to open older cookijar files can turn off UTF-8 Mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-87888