New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-44512: Fix handling of extrasactions arg with mixed or upper case #26924
bpo-44512: Fix handling of extrasactions arg with mixed or upper case #26924
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
|
| Name | Link |
|---|---|
| 0ec0945 | |
| https://app.netlify.com/sites/python-cpython-preview/deploys/639356a3033e74000806e08e |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @iritkatriel: please review the changes made to this pull request. |
|
Is this documented as case insensitive? |
|
@iritkatriel it's not documented as case insensitive but it was already being implemented partly as case insensitive, so this PR is to fix the inconsistency in a way that doesn't break valid old code. |
|
Got it. Please add a news file. |
|
Thanks @akulakov for the PR, and @iritkatriel for merging it |
|
Sorry, @akulakov and @iritkatriel, I could not cleanly backport this to |
|
Sorry @akulakov and @iritkatriel, I had trouble checking out the |
|
@iritkatriel thanks for reviewing! |
https://bugs.python.org/issue44512